Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(534)

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorResourceContentLoader.h

Issue 1436723005: Oilpan: tidy up InspectorResourceContentLoader's ResourceClient handling. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/inspector/InspectorResourceContentLoader.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/inspector/InspectorResourceContentLoader.h
diff --git a/third_party/WebKit/Source/core/inspector/InspectorResourceContentLoader.h b/third_party/WebKit/Source/core/inspector/InspectorResourceContentLoader.h
index 25c71f8e82d8ed0a1ab4824a21d502f51a8bac2e..ff9ab12643f1cbe503541eabb826050f564e7066 100644
--- a/third_party/WebKit/Source/core/inspector/InspectorResourceContentLoader.h
+++ b/third_party/WebKit/Source/core/inspector/InspectorResourceContentLoader.h
@@ -46,8 +46,8 @@ private:
bool m_allRequestsStarted;
bool m_started;
RawPtrWillBeMember<LocalFrame> m_inspectedFrame;
- HashSet<ResourceClient*> m_pendingResourceClients;
- Vector<ResourcePtr<Resource> > m_resources;
+ WillBeHeapHashSet<RawPtrWillBeMember<ResourceClient>> m_pendingResourceClients;
haraken 2015/11/13 11:55:04 Nit: It would be better to make this WillBeHeapHas
sof 2015/11/13 13:57:27 The ResourceClients here self-destruct, which they
+ Vector<ResourcePtr<Resource>> m_resources;
friend class ResourceClient;
};
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/inspector/InspectorResourceContentLoader.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698