Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Side by Side Diff: third_party/WebKit/Source/core/inspector/InspectorResourceContentLoader.h

Issue 1436723005: Oilpan: tidy up InspectorResourceContentLoader's ResourceClient handling. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/inspector/InspectorResourceContentLoader.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef InspectorResourceContentLoader_h 5 #ifndef InspectorResourceContentLoader_h
6 #define InspectorResourceContentLoader_h 6 #define InspectorResourceContentLoader_h
7 7
8 #include "core/CoreExport.h" 8 #include "core/CoreExport.h"
9 #include "core/fetch/ResourcePtr.h" 9 #include "core/fetch/ResourcePtr.h"
10 #include "wtf/Functional.h" 10 #include "wtf/Functional.h"
(...skipping 28 matching lines...) Expand all
39 void resourceFinished(ResourceClient*); 39 void resourceFinished(ResourceClient*);
40 void checkDone(); 40 void checkDone();
41 void start(); 41 void start();
42 void stop(); 42 void stop();
43 bool hasFinished(); 43 bool hasFinished();
44 44
45 Vector<OwnPtr<Closure>> m_callbacks; 45 Vector<OwnPtr<Closure>> m_callbacks;
46 bool m_allRequestsStarted; 46 bool m_allRequestsStarted;
47 bool m_started; 47 bool m_started;
48 RawPtrWillBeMember<LocalFrame> m_inspectedFrame; 48 RawPtrWillBeMember<LocalFrame> m_inspectedFrame;
49 HashSet<ResourceClient*> m_pendingResourceClients; 49 WillBeHeapHashSet<RawPtrWillBeMember<ResourceClient>> m_pendingResourceClien ts;
haraken 2015/11/13 11:55:04 Nit: It would be better to make this WillBeHeapHas
sof 2015/11/13 13:57:27 The ResourceClients here self-destruct, which they
50 Vector<ResourcePtr<Resource> > m_resources; 50 Vector<ResourcePtr<Resource>> m_resources;
51 51
52 friend class ResourceClient; 52 friend class ResourceClient;
53 }; 53 };
54 54
55 } // namespace blink 55 } // namespace blink
56 56
57 57
58 #endif // !defined(InspectorResourceContentLoader_h) 58 #endif // !defined(InspectorResourceContentLoader_h)
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/inspector/InspectorResourceContentLoader.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698