Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 14366040: Fixed spec compliance issues in WebGLRenderingContext. (Closed)

Created:
7 years, 8 months ago by Ken Russell (switch to Gerrit)
Modified:
7 years, 7 months ago
Reviewers:
jamesr, greggman, bajones
CC:
blink-reviews, Jun Jiang
Visibility:
Public.

Description

Fixed spec compliance issues in WebGLRenderingContext. Moved HALF_FLOAT_OES enum to OES_texture_half_float extension where it belongs. Deleted releaseShaderCompiler entry point not in the WebGL spec. Deleted previously incorrectly modified fast/canvas/webgl/constants.html layout test. Updated related layout tests from Khronos repository under webgl/. Once Chromium starts running these tests they will pass. BUG=234842 R=gman@chromium.org,bajones@chromium.org,jamesr@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=149051

Patch Set 1 #

Patch Set 2 : Rebased and retested. #

Messages

Total messages: 7 (0 generated)
Ken Russell (switch to Gerrit)
Please review. Thanks.
7 years, 8 months ago (2013-04-24 01:34:32 UTC) #1
jamesr
Please format the change description as follows: 1 line short description of what the patch ...
7 years, 8 months ago (2013-04-24 17:53:26 UTC) #2
greggman
lgtm now that we are on blink maybe we can enable most of the WebGL ...
7 years, 8 months ago (2013-04-24 18:20:44 UTC) #3
Ken Russell (switch to Gerrit)
On 2013/04/24 18:20:44, greggman wrote: > now that we are on blink maybe we can ...
7 years, 8 months ago (2013-04-24 23:09:20 UTC) #4
Ken Russell (switch to Gerrit)
Committed patchset #2 manually as r149051 (presubmit successful).
7 years, 8 months ago (2013-04-24 23:11:29 UTC) #5
Zhenyao Mo
On 2013/04/24 18:20:44, greggman wrote: > lgtm > > now that we are on blink ...
7 years, 7 months ago (2013-04-29 22:36:29 UTC) #6
Ken Russell (switch to Gerrit)
7 years, 7 months ago (2013-04-29 22:47:13 UTC) #7
Message was sent while issue was closed.
On 2013/04/29 22:36:29, Zhenyao Mo wrote:
> On 2013/04/24 18:20:44, greggman wrote:
> > lgtm
> > 
> > now that we are on blink maybe we can enable most of the WebGL tests in
> > LayoutTests if they are not already.
> 
> Are we still using osmesa for LayoutTests? we should really update the
revision,
> otherwise it's too buggy to cover what we want to cover in webgl layout tests.

Yes, OSMesa is still being used for layout tests.

A contributor is actively working on upgrading the version of Mesa used for this
purpose. Please contact me offline for more information.

Powered by Google App Engine
This is Rietveld 408576698