|
|
Created:
5 years, 1 month ago by Dirk Pranke Modified:
5 years, 1 month ago CC:
chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionFlip Linux x64, linux_chromium_archive_rel_ng bots to GN
This patch adds MB support for the new 'linux_chromium_archive_rel_ng'
bot and flips it and the 'Linux x64' waterfall bot to GN.
This bot should replace the 'linux_chromium_clobber_rel_ng' bot ASAP
since that bot is doing a GYP build of 'chromium_builder_tests',
which isn't that interesting, and the supposed builder that that bot
is mirroring, 'Linux Builder (clobber)' on the chromium.fyi waterfall,
doesn't actually exist.
TBR=phajdan.jr@chromium.org, jam@chromium.org
BUG=545480, 531296
Committed: https://crrev.com/d57baf27aee323ba55d7efbd4e447da4aa393d16
Cr-Commit-Position: refs/heads/master@{#358743}
Patch Set 1 #Patch Set 2 : remove cq part #
Messages
Total messages: 29 (10 generated)
Description was changed from ========== Flip Linux x64, linux_chromium_archive_rel_ng bots to GN and add to CQ. This patch adds MB support for the new 'linux_chromium_archive_rel_ng' bot and flips it and the 'Linux x64' waterfall bot to GN. This also adds the tryserver bot to the CQ at 10% as an experiment. This bot should replace the 'linux_chromium_clobber_rel_ng' bot ASAP since that bot is doing a GYP build of 'chromium_builder_tests', which isn't that interesting, and the supposed builder that that bot is mirroring, 'Linux Builder (clobber)' on the chromium.fyi waterfall, doesn't actually exist. R=phajdan.jr@chromium.org, jam@chromium.org BUG=545480, 531296 ========== to ========== Flip Linux x64, linux_chromium_archive_rel_ng bots to GN This patch adds MB support for the new 'linux_chromium_archive_rel_ng' bot and flips it and the 'Linux x64' waterfall bot to GN. This bot should replace the 'linux_chromium_clobber_rel_ng' bot ASAP since that bot is doing a GYP build of 'chromium_builder_tests', which isn't that interesting, and the supposed builder that that bot is mirroring, 'Linux Builder (clobber)' on the chromium.fyi waterfall, doesn't actually exist. TBR=phajdan.jr@chromium.org, jam@chromium.org BUG=545480, 531296 ==========
Note that this won't actually have an effect on the Linux x64 bot until https://codereview.chromium.org/1412093012/ lands.
The CQ bit was checked by dpranke@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1435513003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1435513003/20001
On 2015/11/07 03:33:36, Dirk Pranke wrote: > Note that this won't actually have an effect on the Linux x64 bot until > https://codereview.chromium.org/1412093012/ lands. TBR'ing so that we can get this CL landed first and test the config on the linux_chormium_archive_rel_ng bot.
For the record, this CL originally also was adding the tryserver to the CQ at a 10% experiment, but I took that part out to minimize the number of changes at once (and the risk).
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_blink_oilpan_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_blink_oil...)
The CQ bit was checked by dpranke@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1435513003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1435513003/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_blink_oilpan_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_blink_oil...)
LGTM
lgtm
The CQ bit was checked by dpranke@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1435513003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1435513003/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_blink_oilpan_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_blink_oil...)
The CQ bit was checked by dpranke@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1435513003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1435513003/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by dpranke@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1435513003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1435513003/20001
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/d57baf27aee323ba55d7efbd4e447da4aa393d16 Cr-Commit-Position: refs/heads/master@{#358743}
Message was sent while issue was closed.
On 2015/11/10 01:59:06, commit-bot: I haz the power wrote: > Patchset 2 (id:??) landed as > https://crrev.com/d57baf27aee323ba55d7efbd4e447da4aa393d16 > Cr-Commit-Position: refs/heads/master@{#358743} This appears to have caused the linux x64 compile to fail. I will revert if this also fails locally and the clobber build underway also fails. It appears that natice_theme is compiled into both libblimp_client and directly, producing duplicate symbols: FAILED: python /b/build/slave/Linux_x64/build/src/build/toolchain/gcc_solink_wrapper.py --readelf=readelf --nm=nm --sofile="./libblimp_client.so" --tocfile="./libblimp_client.so.TOC" --output="./libblimp_client.so" -- ../../third_party/llvm-build/Release+Asserts/bin/clang++ -shared -Wl,--fatal-warnings -fPIC -Wl,-z,noexecstack -Wl,-z,now -Wl,-z,relro -Wl,-z,defs -B../../third_party/binutils/Linux_x64/Release/bin -fuse-ld=gold -Wl,--icf=all -pthread -m64 -Wl,-O1 -Wl,--gc-sections -Wl,--as-needed -Wl,--export-dynamic -o "./libblimp_client.so" -Wl,-soname="libblimp_client.so" @"./libblimp_client.so.rsp" ../../third_party/binutils/Linux_x64/Release/bin/ld.gold: error: obj/ui/native_theme/native_theme/native_theme_switches.o: multiple definition of 'ui::IsOverlayScrollbarEnabled()' ../../third_party/binutils/Linux_x64/Release/bin/ld.gold: obj/blimp/client/libblimp_client/native_theme_switches.o: previous definition here ../../third_party/binutils/Linux_x64/Release/bin/ld.gold: error: obj/ui/native_theme/native_theme/native_theme_switches.o: multiple definition of 'switches::kEnableOverlayScrollbar' ../../third_party/binutils/Linux_x64/Release/bin/ld.gold: obj/blimp/client/libblimp_client/native_theme_switches.o: previous definition here ../../third_party/binutils/Linux_x64/Release/bin/ld.gold: error: obj/ui/native_theme/native_theme/native_theme_switches.o: multiple definition of 'switches::kDisableOverlayScrollbar' ../../third_party/binutils/Linux_x64/Release/bin/ld.gold: obj/blimp/client/libblimp_client/native_theme_switches.o: previous definition here clang: error: linker command failed with exit code 1 (use -v to see invocation) ninja: build stopped: subcommand failed.
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/1416933004/ by petermayo@chromium.org. The reason for reverting is: libblimp_client.so fails to build under gn. Issue 553999 filed and tracking.. |