Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Issue 1435513003: Flip Linux x64, linux_chromium_archive_rel_ng bots to GN (Closed)

Created:
5 years, 1 month ago by Dirk Pranke
Modified:
5 years, 1 month ago
Reviewers:
jam, Paweł Hajdan Jr.
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Flip Linux x64, linux_chromium_archive_rel_ng bots to GN This patch adds MB support for the new 'linux_chromium_archive_rel_ng' bot and flips it and the 'Linux x64' waterfall bot to GN. This bot should replace the 'linux_chromium_clobber_rel_ng' bot ASAP since that bot is doing a GYP build of 'chromium_builder_tests', which isn't that interesting, and the supposed builder that that bot is mirroring, 'Linux Builder (clobber)' on the chromium.fyi waterfall, doesn't actually exist. TBR=phajdan.jr@chromium.org, jam@chromium.org BUG=545480, 531296 Committed: https://crrev.com/d57baf27aee323ba55d7efbd4e447da4aa393d16 Cr-Commit-Position: refs/heads/master@{#358743}

Patch Set 1 #

Patch Set 2 : remove cq part #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -4 lines) Patch
M testing/buildbot/chromium.json View 1 chunk +7 lines, -1 line 0 comments Download
M tools/mb/mb_config.pyl View 4 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 29 (10 generated)
Dirk Pranke
5 years, 1 month ago (2015-11-07 03:25:53 UTC) #1
Dirk Pranke
Note that this won't actually have an effect on the Linux x64 bot until https://codereview.chromium.org/1412093012/ ...
5 years, 1 month ago (2015-11-07 03:33:36 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1435513003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1435513003/20001
5 years, 1 month ago (2015-11-07 03:33:53 UTC) #5
Dirk Pranke
On 2015/11/07 03:33:36, Dirk Pranke wrote: > Note that this won't actually have an effect ...
5 years, 1 month ago (2015-11-07 03:34:09 UTC) #6
Dirk Pranke
For the record, this CL originally also was adding the tryserver to the CQ at ...
5 years, 1 month ago (2015-11-07 03:36:33 UTC) #7
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_blink_oilpan_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_blink_oilpan_rel/builds/1322)
5 years, 1 month ago (2015-11-07 05:07:23 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1435513003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1435513003/20001
5 years, 1 month ago (2015-11-07 19:01:41 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_oilpan_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_blink_oilpan_rel/builds/1357)
5 years, 1 month ago (2015-11-07 20:36:18 UTC) #13
Paweł Hajdan Jr.
LGTM
5 years, 1 month ago (2015-11-09 10:39:44 UTC) #14
jam
lgtm
5 years, 1 month ago (2015-11-09 16:50:37 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1435513003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1435513003/20001
5 years, 1 month ago (2015-11-09 19:49:54 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_oilpan_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_blink_oilpan_rel/builds/1622)
5 years, 1 month ago (2015-11-09 20:47:23 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1435513003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1435513003/20001
5 years, 1 month ago (2015-11-09 20:52:56 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/126547)
5 years, 1 month ago (2015-11-09 21:36:23 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1435513003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1435513003/20001
5 years, 1 month ago (2015-11-10 00:44:20 UTC) #25
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-10 01:57:20 UTC) #26
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/d57baf27aee323ba55d7efbd4e447da4aa393d16 Cr-Commit-Position: refs/heads/master@{#358743}
5 years, 1 month ago (2015-11-10 01:59:06 UTC) #27
Peter Mayo
On 2015/11/10 01:59:06, commit-bot: I haz the power wrote: > Patchset 2 (id:??) landed as ...
5 years, 1 month ago (2015-11-10 14:05:34 UTC) #28
Peter Mayo
5 years, 1 month ago (2015-11-10 14:16:18 UTC) #29
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1416933004/ by petermayo@chromium.org.

The reason for reverting is: libblimp_client.so fails to build under gn.

Issue 553999 filed and tracking..

Powered by Google App Engine
This is Rietveld 408576698