Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 1416933004: Revert of Flip Linux x64, linux_chromium_archive_rel_ng bots to GN (Closed)

Created:
5 years, 1 month ago by Peter Mayo
Modified:
5 years, 1 month ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Flip Linux x64, linux_chromium_archive_rel_ng bots to GN (patchset #2 id:20001 of https://codereview.chromium.org/1435513003/ ) Reason for revert: libblimp_client.so fails to build under gn. Issue 553999 filed and tracking. Original issue's description: > Flip Linux x64, linux_chromium_archive_rel_ng bots to GN > > This patch adds MB support for the new 'linux_chromium_archive_rel_ng' > bot and flips it and the 'Linux x64' waterfall bot to GN. > > This bot should replace the 'linux_chromium_clobber_rel_ng' bot ASAP > since that bot is doing a GYP build of 'chromium_builder_tests', > which isn't that interesting, and the supposed builder that that bot > is mirroring, 'Linux Builder (clobber)' on the chromium.fyi waterfall, > doesn't actually exist. > > TBR=phajdan.jr@chromium.org, jam@chromium.org > BUG=545480, 531296 > > Committed: https://crrev.com/d57baf27aee323ba55d7efbd4e447da4aa393d16 > Cr-Commit-Position: refs/heads/master@{#358743} TBR=phajdan.jr@chromium.org,jam@chromium.org,dpranke@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=545480, 531296 Committed: https://crrev.com/af229b2ae84edd77a6c5c40adf5e34c88805d630 Cr-Commit-Position: refs/heads/master@{#358828}

Patch Set 1 #

Patch Set 2 : Resolve conflict. Manual recreate. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -7 lines) Patch
M testing/buildbot/chromium.json View 1 1 chunk +0 lines, -3 lines 0 comments Download
M tools/mb/mb_config.pyl View 1 4 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
Peter Mayo
Created Revert of Flip Linux x64, linux_chromium_archive_rel_ng bots to GN
5 years, 1 month ago (2015-11-10 14:16:18 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1416933004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1416933004/1
5 years, 1 month ago (2015-11-10 14:16:28 UTC) #2
commit-bot: I haz the power
Failed to apply patch for testing/buildbot/chromium.json: While running git apply --index -3 -p1; error: patch ...
5 years, 1 month ago (2015-11-10 14:16:54 UTC) #4
Paweł Hajdan Jr.
LGTM
5 years, 1 month ago (2015-11-10 14:46:57 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1416933004/70001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1416933004/70001
5 years, 1 month ago (2015-11-10 14:51:50 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:70001)
5 years, 1 month ago (2015-11-10 14:52:33 UTC) #9
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/af229b2ae84edd77a6c5c40adf5e34c88805d630 Cr-Commit-Position: refs/heads/master@{#358828}
5 years, 1 month ago (2015-11-10 14:53:20 UTC) #10
Dirk Pranke
5 years, 1 month ago (2015-11-10 16:57:27 UTC) #11
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698