Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issue 1456483002: [Interpreter] Add New, CallRuntime and CallJSRuntime support to BytecodeGraphBuilder. (Closed)

Created:
5 years, 1 month ago by oth
Modified:
5 years, 1 month ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@rmcilroy-0001-globals
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Interpreter] Add New, CallRuntime and CallJSRuntime support to BytecodeGraphBuilder. Adds support for the New, CallRuntime and CallJSRuntime bytecodes in BytecodeGraphBuilder. Also adds BuildLoadObjectField, BuildLoadGlobalObject and BuildLoadNativeContextField helpers. Landed on behalf of rmcilroy. BUG=v8:4280 LOG=N Committed: https://crrev.com/8cfa73ac38e7640057a14c4a29ea315d9d968039 Cr-Commit-Position: refs/heads/master@{#32136}

Patch Set 1 #

Patch Set 2 : Correct rebasing bogons. #

Patch Set 3 : Signed/unsigned compilation fix. #

Patch Set 4 : Add unittests for New/CallRuntime/CallJSRuntime. #

Patch Set 5 : Fill-in a couple of wildcards. #

Patch Set 6 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+292 lines, -21 lines) Patch
M src/compiler/bytecode-graph-builder.h View 1 2 3 4 5 2 chunks +15 lines, -3 lines 0 comments Download
M src/compiler/bytecode-graph-builder.cc View 1 2 3 4 5 5 chunks +87 lines, -9 lines 0 comments Download
M src/interpreter/interpreter.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/compiler/test-run-bytecode-graph-builder.cc View 1 2 3 4 5 2 chunks +69 lines, -0 lines 0 comments Download
M test/cctest/interpreter/test-bytecode-generator.cc View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M test/unittests/compiler/bytecode-graph-builder-unittest.cc View 1 2 3 4 5 1 chunk +86 lines, -0 lines 0 comments Download
M test/unittests/compiler/node-test-utils.h View 1 2 3 4 5 1 chunk +6 lines, -0 lines 0 comments Download
M test/unittests/compiler/node-test-utils.cc View 1 2 3 4 5 3 chunks +28 lines, -7 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
oth
Benedikt, Mythrie: please take a look. Thanks!
5 years, 1 month ago (2015-11-19 14:22:38 UTC) #3
mythria
lgtm Thanks, Mythri
5 years, 1 month ago (2015-11-19 14:41:29 UTC) #4
Benedikt Meurer
LGTM on compiler.
5 years, 1 month ago (2015-11-19 19:43:46 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1456483002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1456483002/100001
5 years, 1 month ago (2015-11-20 09:03:52 UTC) #8
commit-bot: I haz the power
Committed patchset #6 (id:100001)
5 years, 1 month ago (2015-11-20 09:25:18 UTC) #9
commit-bot: I haz the power
5 years, 1 month ago (2015-11-20 09:25:51 UTC) #10
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/8cfa73ac38e7640057a14c4a29ea315d9d968039
Cr-Commit-Position: refs/heads/master@{#32136}

Powered by Google App Engine
This is Rietveld 408576698