Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Unified Diff: src/IceTargetLoweringARM32.h

Issue 1435363002: Merge fixed alloca stack adjustments into the prolog (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Final code review comments Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/IceTargetLowering.cpp ('k') | src/IceTargetLoweringMIPS32.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/IceTargetLoweringARM32.h
diff --git a/src/IceTargetLoweringARM32.h b/src/IceTargetLoweringARM32.h
index 969e17a6b49c9ac8cdfdfcbfa400a53a058b1551..20f3597e88d4ca644df89628dc4f26e9703dce1b 100644
--- a/src/IceTargetLoweringARM32.h
+++ b/src/IceTargetLoweringARM32.h
@@ -86,8 +86,9 @@ public:
bool hasFramePointer() const override { return UsesFramePointer; }
void setHasFramePointer() override { UsesFramePointer = true; }
SizeT getStackReg() const override { return RegARM32::Reg_sp; }
+ SizeT getFrameReg() const override { return RegARM32::Reg_fp; }
SizeT getFrameOrStackReg() const override {
- return UsesFramePointer ? RegARM32::Reg_fp : RegARM32::Reg_sp;
+ return UsesFramePointer ? getFrameReg() : getStackReg();
}
SizeT getReservedTmpReg() const { return RegARM32::Reg_ip; }
@@ -97,6 +98,17 @@ public:
return (typeWidthInBytes(Ty) + 3) & ~3;
}
uint32_t getStackAlignment() const override;
+ void reserveFixedAllocaArea(size_t Size, size_t Align) override {
+ // TODO(sehr,jpp): Implement fixed stack layout.
+ (void)Size;
+ (void)Align;
+ llvm::report_fatal_error("Not yet implemented");
+ }
+ int32_t getFrameFixedAllocaOffset() const override {
+ // TODO(sehr,jpp): Implement fixed stack layout.
+ llvm::report_fatal_error("Not yet implemented");
+ return 0;
+ }
bool shouldSplitToVariable64On32(Type Ty) const override {
return Ty == IceType_i64;
« no previous file with comments | « src/IceTargetLowering.cpp ('k') | src/IceTargetLoweringMIPS32.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698