Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 1435333005: Remove unused CheckSvnModifiedDirectories. (Closed)

Created:
5 years, 1 month ago by Lei Zhang
Modified:
5 years, 1 month ago
Reviewers:
M-A Ruel
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org, Paweł Hajdan Jr.
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove unused CheckSvnModifiedDirectories. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=297676

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -63 lines) Patch
M presubmit_canned_checks.py View 1 chunk +0 lines, -36 lines 0 comments Download
M tests/presubmit_unittest.py View 2 chunks +0 lines, -27 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Lei Zhang
5 years, 1 month ago (2015-11-13 06:57:08 UTC) #2
M-A Ruel
lgtm assuming Pawel is fine too.
5 years, 1 month ago (2015-11-13 19:17:44 UTC) #3
Lei Zhang
I'm going to assume this is fine.
5 years, 1 month ago (2015-11-23 22:53:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1435333005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1435333005/1
5 years, 1 month ago (2015-11-23 22:54:13 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-11-23 23:07:40 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=297676

Powered by Google App Engine
This is Rietveld 408576698