Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Unified Diff: tests/presubmit_unittest.py

Issue 1435333005: Remove unused CheckSvnModifiedDirectories. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « presubmit_canned_checks.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/presubmit_unittest.py
diff --git a/tests/presubmit_unittest.py b/tests/presubmit_unittest.py
index d72b6b1e885c4f72298929c4970ac4f00a9d9630..66d97f84cf93f3c1f0a2bf637216289f9ec361ef 100755
--- a/tests/presubmit_unittest.py
+++ b/tests/presubmit_unittest.py
@@ -1887,7 +1887,6 @@ class CannedChecksUnittest(PresubmitTestsBase):
'CheckGNFormatted',
'CheckRietveldTryJobExecution',
'CheckSingletonInHeaders',
- 'CheckSvnModifiedDirectories',
'CheckSvnForCommonMimeTypes', 'CheckSvnProperty',
'RunPythonUnitTests', 'RunPylint',
'RunUnitTests', 'RunUnitTestsInDirectory',
@@ -2334,32 +2333,6 @@ class CannedChecksUnittest(PresubmitTestsBase):
)
self._LicenseCheck(text, license_text, True, None, accept_empty_files=True)
- def testCannedCheckSvnAccidentalSubmission(self):
- modified_dir_file = 'foo/'
- accidental_submssion_file = 'foo/bar.cc'
-
- change = self.mox.CreateMock(presubmit.SvnChange)
- change.scm = 'svn'
- change.GetModifiedFiles().AndReturn([modified_dir_file])
- change.GetAllModifiedFiles().AndReturn([modified_dir_file,
- accidental_submssion_file])
- input_api = self.MockInputApi(change, True)
-
- affected_file = self.mox.CreateMock(presubmit.SvnAffectedFile)
- affected_file.Action().AndReturn('M')
- affected_file.IsDirectory().AndReturn(True)
- affected_file.AbsoluteLocalPath().AndReturn(accidental_submssion_file)
- affected_file.LocalPath().AndReturn(accidental_submssion_file)
- input_api.AffectedFiles(file_filter=None).AndReturn([affected_file])
-
- self.mox.ReplayAll()
-
- check = presubmit_canned_checks.CheckSvnModifiedDirectories
- results = check(input_api, presubmit.OutputApi, None)
- self.assertEquals(len(results), 1)
- self.assertEquals(results[0].__class__,
- presubmit.OutputApi.PresubmitPromptWarning)
-
def testCheckSvnForCommonMimeTypes(self):
self.mox.StubOutWithMock(presubmit_canned_checks, 'CheckSvnProperty')
input_api = self.MockInputApi(None, False)
« no previous file with comments | « presubmit_canned_checks.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698