Remove unused CheckSvnModifiedDirectories.

presubmit_canned_checks.py

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Generic presubmit checks that can be reused by other presubmit checks."""
 
 import os as _os
 _HERE = _os.path.dirname(_os.path.abspath(__file__))
 
 # Justifications for each filter:
@@ skipping 143 matching lines @@
   cr_files = []
   for f in input_api.AffectedSourceFiles(source_file_filter):
     if '\r' in input_api.ReadFile(f, 'rb'):
       cr_files.append(f.LocalPath())
   if cr_files:
     return [output_api.PresubmitPromptWarning(
         'Found a CR character in these files:', items=cr_files)]
   return []
 
 
-def CheckSvnModifiedDirectories(input_api, output_api, source_file_filter=None):
-  """Checks for files in svn modified directories.
-
-  They will get submitted on accident because svn commits recursively by
-  default, and that's very dangerous.
-  """
-  if input_api.change.scm != 'svn':
-    return []
-
-  errors = []
-  current_cl_files = input_api.change.GetModifiedFiles()
-  all_modified_files = input_api.change.GetAllModifiedFiles()
-  # Filter out files in the current CL.
-  modified_files = [f for f in all_modified_files if f not in current_cl_files]
-  modified_abspaths = [input_api.os_path.abspath(f) for f in modified_files]
-
-  for f in input_api.AffectedFiles(file_filter=source_file_filter):
-    if f.Action() == 'M' and f.IsDirectory():
-      curpath = f.AbsoluteLocalPath()
-      bad_files = []
-      # Check if any of the modified files in other CLs are under curpath.
-      for i in xrange(len(modified_files)):
-        abspath = modified_abspaths[i]
-        if input_api.os_path.commonprefix([curpath, abspath]) == curpath:
-          bad_files.append(modified_files[i])
-      if bad_files:
-        if input_api.is_committing:
-          error_type = output_api.PresubmitPromptWarning
-        else:
-          error_type = output_api.PresubmitNotifyResult
-        errors.append(error_type(
-            'Potential accidental commits in changelist %s:' % f.LocalPath(),
-            items=bad_files))
-  return errors
-
-
 def CheckChangeHasOnlyOneEol(input_api, output_api, source_file_filter=None):
   """Checks the files ends with one and only one \n (LF)."""
   eof_files = []
   for f in input_api.AffectedSourceFiles(source_file_filter):
     contents = input_api.ReadFile(f, 'rb')
     # Check that the file ends in one and only one newline character.
     if len(contents) > 1 and (contents[-1:] != '\n' or contents[-2:-1] == '\n'):
       eof_files.append(f.LocalPath())
 
   if eof_files:
@@ skipping 948 matching lines @@
   for f in affected_files:
     cmd = ['gn', 'format', '--dry-run', f.AbsoluteLocalPath()]
     rc = gn.main(cmd)
     if rc == 2:
       warnings.append(output_api.PresubmitPromptWarning(
           '%s requires formatting. Please run `gn format --in-place %s`.' % (
               f.AbsoluteLocalPath(), f.LocalPath())))
   # It's just a warning, so ignore other types of failures assuming they'll be
   # caught elsewhere.
   return warnings