Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Issue 1435743004: Move PrivetV3ContextGetter into separate file next to privet_v3_session (Closed)

Created:
5 years, 1 month ago by Vitaly Buka (NO REVIEWS)
Modified:
5 years, 1 month ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move PrivetV3ContextGetter into separate file next to privet_v3_session Code move only, no changes in logic. PrivetV3ContextGetter is going to be used by gcd_private API BUG=551631 Committed: https://crrev.com/ceae22bb94b76976800fa6d78f40e002cff9e35a Cr-Commit-Position: refs/heads/master@{#359209}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+140 lines, -85 lines) Patch
A chrome/browser/extensions/api/gcd_private/privet_v3_context_getter.h View 1 chunk +49 lines, -0 lines 0 comments Download
A chrome/browser/extensions/api/gcd_private/privet_v3_context_getter.cc View 1 chunk +87 lines, -0 lines 0 comments Download
M chrome/browser/local_discovery/privet_http_impl.cc View 3 chunks +2 lines, -85 lines 0 comments Download
M chrome/chrome_browser_extensions.gypi View 1 chunk +2 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 15 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1435743004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1435743004/1
5 years, 1 month ago (2015-11-11 03:04:25 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-11 03:43:07 UTC) #8
Aleksey Shlyapnikov
lgtm
5 years, 1 month ago (2015-11-12 00:08:45 UTC) #9
davidben
(Did you want me to review this? I notice I'm a reviewer but didn't actually ...
5 years, 1 month ago (2015-11-12 00:11:30 UTC) #10
Vitaly Buka (NO REVIEWS)
On 2015/11/12 00:11:30, davidben wrote: > (Did you want me to review this? I notice ...
5 years, 1 month ago (2015-11-12 00:53:22 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1435743004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1435743004/1
5 years, 1 month ago (2015-11-12 00:54:01 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-12 02:34:14 UTC) #14
commit-bot: I haz the power
5 years, 1 month ago (2015-11-12 20:02:48 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ceae22bb94b76976800fa6d78f40e002cff9e35a
Cr-Commit-Position: refs/heads/master@{#359209}

Powered by Google App Engine
This is Rietveld 408576698