Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 1435053002: Register super field set explicitly in the universe. (Closed)

Created:
5 years, 1 month ago by Johnni Winther
Modified:
5 years ago
Reviewers:
sra1
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Fix codegen #

Patch Set 3 : Rebased #

Patch Set 4 : Rebased #

Patch Set 5 : Checked mode fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -19 lines) Patch
M pkg/compiler/lib/src/enqueue.dart View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/program_builder/field_visitor.dart View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/resolution/members.dart View 1 2 3 3 chunks +17 lines, -8 lines 0 comments Download
M pkg/compiler/lib/src/ssa/codegen.dart View 1 1 chunk +3 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/universe/universe.dart View 1 2 3 4 2 chunks +4 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/universe/use.dart View 2 chunks +14 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/world.dart View 1 2 3 4 1 chunk +8 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
Johnni Winther
Main changes in universe/use.dart and universe/universe.dart
5 years, 1 month ago (2015-11-11 19:08:15 UTC) #2
sra1
LGTM! Thanks!
5 years, 1 month ago (2015-11-13 22:02:05 UTC) #3
sra1
Committed patchset #2 (id:20001) manually as df5bc72927e48479a9cc4599578e99fb14a3c441 (presubmit successful).
5 years, 1 month ago (2015-11-13 23:52:43 UTC) #4
Johnni Winther
Trying to commit again. Couldn't reproduce any of the errors locally.
5 years, 1 month ago (2015-11-20 11:49:39 UTC) #6
Johnni Winther
Committed patchset #3 (id:40001) manually as 2345d845f5022fa9d880f06602c9cc85bc95de12 (presubmit successful).
5 years, 1 month ago (2015-11-20 12:10:48 UTC) #7
Johnni Winther
PTAL @ the last patch
5 years, 1 month ago (2015-11-20 16:30:09 UTC) #9
sra1
lgtm
5 years, 1 month ago (2015-11-20 19:22:07 UTC) #10
Johnni Winther
5 years ago (2015-11-30 10:16:44 UTC) #12
Message was sent while issue was closed.
Committed patchset #5 (id:80001) manually as
1dabe1f8e99c5604bac648a1664a51b99f7901a2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698