Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(838)

Unified Diff: pkg/compiler/lib/src/world.dart

Issue 1435053002: Register super field set explicitly in the universe. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Checked mode fix Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/universe/use.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/world.dart
diff --git a/pkg/compiler/lib/src/world.dart b/pkg/compiler/lib/src/world.dart
index b4860b88e4acbae96c1544cd5aefdca422057f59..8fd7e6c9724f481bbbd36bf24bf96d83c1769c63 100644
--- a/pkg/compiler/lib/src/world.dart
+++ b/pkg/compiler/lib/src/world.dart
@@ -675,10 +675,14 @@ class World implements ClassWorld {
return false;
}
- return element.isFinal
- || element.isConst
- || (element.isInstanceMember
- && !compiler.resolverWorld.hasInvokedSetter(element, this));
+ if (element.isFinal || element.isConst) {
+ return true;
+ }
+ if (element.isInstanceMember) {
+ return !compiler.resolverWorld.hasInvokedSetter(element, this) &&
+ !compiler.resolverWorld.fieldSetters.contains(element);
+ }
+ return false;
}
SideEffects getSideEffectsOfElement(Element element) {
« no previous file with comments | « pkg/compiler/lib/src/universe/use.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698