Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1237)

Unified Diff: pkg/compiler/lib/src/resolution/members.dart

Issue 1435053002: Register super field set explicitly in the universe. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Checked mode fix Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/resolution/members.dart
diff --git a/pkg/compiler/lib/src/resolution/members.dart b/pkg/compiler/lib/src/resolution/members.dart
index 6d41d9ca88a85d18c7cc521fe365a11563379717..c41d5a1517f135e38515b03ed4cf5b3bc0ec6af4 100644
--- a/pkg/compiler/lib/src/resolution/members.dart
+++ b/pkg/compiler/lib/src/resolution/members.dart
@@ -3361,13 +3361,14 @@ class ResolverVisitor extends MappingVisitor<ResolutionResult> {
registry.registerStaticUse(new StaticUse.superGet(semantics.getter));
break;
case AccessKind.SUPER_SETTER:
- registry.registerStaticUse(new StaticUse.superSet(semantics.setter));
+ registry.registerStaticUse(
+ new StaticUse.superSetterSet(semantics.setter));
break;
case AccessKind.SUPER_FIELD:
registry.registerStaticUse(
new StaticUse.superGet(semantics.element));
registry.registerStaticUse(
- new StaticUse.superSet(semantics.element));
+ new StaticUse.superFieldSet(semantics.element));
break;
case AccessKind.SUPER_FINAL_FIELD:
registry.registerStaticUse(
@@ -3376,22 +3377,27 @@ class ResolverVisitor extends MappingVisitor<ResolutionResult> {
case AccessKind.COMPOUND:
CompoundAccessSemantics compoundSemantics = semantics;
switch (compoundSemantics.compoundAccessKind) {
- case CompoundAccessKind.SUPER_GETTER_SETTER:
case CompoundAccessKind.SUPER_GETTER_FIELD:
- case CompoundAccessKind.SUPER_FIELD_SETTER:
case CompoundAccessKind.SUPER_FIELD_FIELD:
registry.registerStaticUse(
new StaticUse.superGet(semantics.getter));
registry.registerStaticUse(
- new StaticUse.superSet(semantics.setter));
+ new StaticUse.superFieldSet(semantics.setter));
+ break;
+ case CompoundAccessKind.SUPER_FIELD_SETTER:
+ case CompoundAccessKind.SUPER_GETTER_SETTER:
+ registry.registerStaticUse(
+ new StaticUse.superGet(semantics.getter));
+ registry.registerStaticUse(
+ new StaticUse.superSetterSet(semantics.setter));
break;
case CompoundAccessKind.SUPER_METHOD_SETTER:
registry.registerStaticUse(
- new StaticUse.superSet(semantics.setter));
+ new StaticUse.superSetterSet(semantics.setter));
break;
case CompoundAccessKind.UNRESOLVED_SUPER_GETTER:
registry.registerStaticUse(
- new StaticUse.superSet(semantics.setter));
+ new StaticUse.superSetterSet(semantics.setter));
break;
case CompoundAccessKind.UNRESOLVED_SUPER_SETTER:
registry.registerStaticUse(
@@ -3446,9 +3452,12 @@ class ResolverVisitor extends MappingVisitor<ResolutionResult> {
registry.registerFeature(Feature.SUPER_NO_SUCH_METHOD);
break;
case AccessKind.SUPER_FIELD:
+ registry.registerStaticUse(
+ new StaticUse.superFieldSet(semantics.setter));
+ break;
case AccessKind.SUPER_SETTER:
registry.registerStaticUse(
- new StaticUse.superSet(semantics.setter));
+ new StaticUse.superSetterSet(semantics.setter));
break;
default:
break;
« no previous file with comments | « pkg/compiler/lib/src/js_emitter/program_builder/field_visitor.dart ('k') | pkg/compiler/lib/src/ssa/codegen.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698