Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1434883002: Rename ContentSettings.PermissionActions histogram to Permission.Actions (Closed)

Created:
5 years, 1 month ago by tsergeant
Modified:
5 years, 1 month ago
CC:
asvitkine+watch_chromium.org, chrome-apps-syd-reviews_chromium.org, chromium-reviews, kcarattini+watch_chromium.org, mlamouri+watch-permissions_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename ContentSettings.PermissionActions histogram to Permission.Actions BUG=554419 Committed: https://crrev.com/c993075326ee45e920e80a6cee79fc98b0440c09 Cr-Commit-Position: refs/heads/master@{#361062}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -18 lines) Patch
M chrome/browser/permissions/permission_uma_util.cc View 1 chunk +19 lines, -18 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 5 chunks +35 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
tsergeant
+mlamouri@ for c/b/permissions and isherman@ for histograms PTAL! This is a follow-up from https://codereview.chromium.org/1401073002
5 years, 1 month ago (2015-11-12 04:47:07 UTC) #3
Ilya Sherman
LGTM
5 years, 1 month ago (2015-11-13 01:39:53 UTC) #4
mlamouri (slow - plz ping)
lgtm Sorry for the delay :(
5 years, 1 month ago (2015-11-20 21:14:12 UTC) #5
tsergeant
On 2015/11/20 at 21:14:12, mlamouri wrote: > lgtm > > Sorry for the delay :( ...
5 years, 1 month ago (2015-11-22 23:38:01 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1434883002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1434883002/1
5 years, 1 month ago (2015-11-22 23:38:16 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-23 00:59:12 UTC) #9
commit-bot: I haz the power
5 years, 1 month ago (2015-11-23 01:00:15 UTC) #10
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/c993075326ee45e920e80a6cee79fc98b0440c09
Cr-Commit-Position: refs/heads/master@{#361062}

Powered by Google App Engine
This is Rietveld 408576698