Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Side by Side Diff: chrome/browser/permissions/permission_uma_util.cc

Issue 1434883002: Rename ContentSettings.PermissionActions histogram to Permission.Actions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/permissions/permission_uma_util.h" 5 #include "chrome/browser/permissions/permission_uma_util.h"
6 6
7 #include "base/metrics/histogram_macros.h" 7 #include "base/metrics/histogram_macros.h"
8 #include "base/strings/stringprintf.h" 8 #include "base/strings/stringprintf.h"
9 #include "chrome/browser/browser_process.h" 9 #include "chrome/browser/browser_process.h"
10 #include "chrome/browser/permissions/permission_manager.h" 10 #include "chrome/browser/permissions/permission_manager.h"
(...skipping 77 matching lines...) Expand 10 before | Expand all | Expand 10 after
88 88
89 void RecordPermissionAction(ContentSettingsType permission, 89 void RecordPermissionAction(ContentSettingsType permission,
90 PermissionAction action, 90 PermissionAction action,
91 const GURL& requesting_origin) { 91 const GURL& requesting_origin) {
92 bool secure_origin = content::IsOriginSecure(requesting_origin); 92 bool secure_origin = content::IsOriginSecure(requesting_origin);
93 93
94 switch (permission) { 94 switch (permission) {
95 case CONTENT_SETTINGS_TYPE_GEOLOCATION: 95 case CONTENT_SETTINGS_TYPE_GEOLOCATION:
96 PERMISSION_ACTION_UMA( 96 PERMISSION_ACTION_UMA(
97 secure_origin, 97 secure_origin,
98 "ContentSettings.PermissionActions_Geolocation", 98 "Permissions.Action.Geolocation",
99 "ContentSettings.PermissionActionsSecureOrigin_Geolocation", 99 "Permissions.Action.SecureOrigin.Geolocation",
100 "ContentSettings.PermissionActionsInsecureOrigin_Geolocation", 100 "Permissions.Action.InsecureOrigin.Geolocation",
101 action); 101 action);
102 break; 102 break;
103 case CONTENT_SETTINGS_TYPE_NOTIFICATIONS: 103 case CONTENT_SETTINGS_TYPE_NOTIFICATIONS:
104 PERMISSION_ACTION_UMA( 104 PERMISSION_ACTION_UMA(
105 secure_origin, 105 secure_origin,
106 "ContentSettings.PermissionActions_Notifications", 106 "Permissions.Action.Notifications",
107 "ContentSettings.PermissionActionsSecureOrigin_Notifications", 107 "Permissions.Action.SecureOrigin.Notifications",
108 "ContentSettings.PermissionActionsInsecureOrigin_Notifications", 108 "Permissions.Action.InsecureOrigin.Notifications",
109 action); 109 action);
110 break; 110 break;
111 case CONTENT_SETTINGS_TYPE_MIDI_SYSEX: 111 case CONTENT_SETTINGS_TYPE_MIDI_SYSEX:
112 PERMISSION_ACTION_UMA( 112 PERMISSION_ACTION_UMA(
113 secure_origin, 113 secure_origin,
114 "ContentSettings.PermissionActions_MidiSysEx", 114 "Permissions.Action.MidiSysEx",
115 "ContentSettings.PermissionActionsSecureOrigin_MidiSysEx", 115 "Permissions.Action.SecureOrigin.MidiSysEx",
116 "ContentSettings.PermissionActionsInsecureOrigin_MidiSysEx", 116 "Permissions.Action.InsecureOrigin.MidiSysEx",
117 action); 117 action);
118 break; 118 break;
119 case CONTENT_SETTINGS_TYPE_PUSH_MESSAGING: 119 case CONTENT_SETTINGS_TYPE_PUSH_MESSAGING:
120 PERMISSION_ACTION_UMA( 120 PERMISSION_ACTION_UMA(
121 secure_origin, 121 secure_origin,
122 "ContentSettings.PermissionActions_PushMessaging", 122 "Permissions.Action.PushMessaging",
123 "ContentSettings.PermissionActionsSecureOrigin_PushMessaging", 123 "Permissions.Action.SecureOrigin.PushMessaging",
124 "ContentSettings.PermissionActionsInsecureOrigin_PushMessaging", 124 "Permissions.Action.InsecureOrigin.PushMessaging",
125 action); 125 action);
126 break; 126 break;
127 #if defined(OS_ANDROID) || defined(OS_CHROMEOS) 127 #if defined(OS_ANDROID) || defined(OS_CHROMEOS)
128 case CONTENT_SETTINGS_TYPE_PROTECTED_MEDIA_IDENTIFIER: 128 case CONTENT_SETTINGS_TYPE_PROTECTED_MEDIA_IDENTIFIER:
129 PERMISSION_ACTION_UMA( 129 PERMISSION_ACTION_UMA(
130 secure_origin, 130 secure_origin,
131 "ContentSettings.PermissionActions_ProtectedMedia", 131 "Permissions.Action.ProtectedMedia",
132 "ContentSettings.PermissionActionsSecureOrigin_ProtectedMedia", 132 "Permissions.Action.SecureOrigin.ProtectedMedia",
133 "ContentSettings.PermissionActionsInsecureOrigin_ProtectedMedia", 133 "Permissions.Action.InsecureOrigin.ProtectedMedia",
134 action); 134 action);
135 break; 135 break;
136 #endif 136 #endif
137 case CONTENT_SETTINGS_TYPE_DURABLE_STORAGE: 137 case CONTENT_SETTINGS_TYPE_DURABLE_STORAGE:
138 PERMISSION_ACTION_UMA( 138 PERMISSION_ACTION_UMA(
139 secure_origin, "ContentSettings.PermissionActions_DurableStorage", 139 secure_origin,
140 "ContentSettings.PermissionActionsSecureOrigin_DurableStorage", 140 "Permissions.Action.DurableStorage",
141 "ContentSettings.PermissionActionsInsecureOrigin_DurableStorage", 141 "Permissions.Action.SecureOrigin.DurableStorage",
142 "Permissions.Action.InsecureOrigin.DurableStorage",
142 action); 143 action);
143 break; 144 break;
144 case CONTENT_SETTINGS_TYPE_MEDIASTREAM_MIC: 145 case CONTENT_SETTINGS_TYPE_MEDIASTREAM_MIC:
145 // Media permissions are disabled on insecure origins, so there's no 146 // Media permissions are disabled on insecure origins, so there's no
146 // need to record metrics for secure/insecue. 147 // need to record metrics for secure/insecue.
147 UMA_HISTOGRAM_ENUMERATION("Permissions.Action.AudioCapture", action, 148 UMA_HISTOGRAM_ENUMERATION("Permissions.Action.AudioCapture", action,
148 PERMISSION_ACTION_NUM); 149 PERMISSION_ACTION_NUM);
149 break; 150 break;
150 case CONTENT_SETTINGS_TYPE_MEDIASTREAM_CAMERA: 151 case CONTENT_SETTINGS_TYPE_MEDIASTREAM_CAMERA:
151 UMA_HISTOGRAM_ENUMERATION("Permissions.Action.VideoCapture", action, 152 UMA_HISTOGRAM_ENUMERATION("Permissions.Action.VideoCapture", action,
(...skipping 164 matching lines...) Expand 10 before | Expand all | Expand 10 after
316 317
317 void PermissionUmaUtil::PermissionDismissed( 318 void PermissionUmaUtil::PermissionDismissed(
318 ContentSettingsType permission, const GURL& requesting_origin) { 319 ContentSettingsType permission, const GURL& requesting_origin) {
319 RecordPermissionAction(permission, DISMISSED, requesting_origin); 320 RecordPermissionAction(permission, DISMISSED, requesting_origin);
320 } 321 }
321 322
322 void PermissionUmaUtil::PermissionIgnored( 323 void PermissionUmaUtil::PermissionIgnored(
323 ContentSettingsType permission, const GURL& requesting_origin) { 324 ContentSettingsType permission, const GURL& requesting_origin) {
324 RecordPermissionAction(permission, IGNORED, requesting_origin); 325 RecordPermissionAction(permission, IGNORED, requesting_origin);
325 } 326 }
OLDNEW
« no previous file with comments | « no previous file | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698