Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Unified Diff: chrome/browser/permissions/permission_uma_util.cc

Issue 1434883002: Rename ContentSettings.PermissionActions histogram to Permission.Actions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/permissions/permission_uma_util.cc
diff --git a/chrome/browser/permissions/permission_uma_util.cc b/chrome/browser/permissions/permission_uma_util.cc
index b9e60b2e0fa912cf1092ba6a7dc06ceaf94640e8..328e6853dea3b92e1f0cedbba821f638bf20dc73 100644
--- a/chrome/browser/permissions/permission_uma_util.cc
+++ b/chrome/browser/permissions/permission_uma_util.cc
@@ -95,50 +95,51 @@ void RecordPermissionAction(ContentSettingsType permission,
case CONTENT_SETTINGS_TYPE_GEOLOCATION:
PERMISSION_ACTION_UMA(
secure_origin,
- "ContentSettings.PermissionActions_Geolocation",
- "ContentSettings.PermissionActionsSecureOrigin_Geolocation",
- "ContentSettings.PermissionActionsInsecureOrigin_Geolocation",
+ "Permissions.Action.Geolocation",
+ "Permissions.Action.SecureOrigin.Geolocation",
+ "Permissions.Action.InsecureOrigin.Geolocation",
action);
break;
case CONTENT_SETTINGS_TYPE_NOTIFICATIONS:
PERMISSION_ACTION_UMA(
secure_origin,
- "ContentSettings.PermissionActions_Notifications",
- "ContentSettings.PermissionActionsSecureOrigin_Notifications",
- "ContentSettings.PermissionActionsInsecureOrigin_Notifications",
+ "Permissions.Action.Notifications",
+ "Permissions.Action.SecureOrigin.Notifications",
+ "Permissions.Action.InsecureOrigin.Notifications",
action);
break;
case CONTENT_SETTINGS_TYPE_MIDI_SYSEX:
PERMISSION_ACTION_UMA(
secure_origin,
- "ContentSettings.PermissionActions_MidiSysEx",
- "ContentSettings.PermissionActionsSecureOrigin_MidiSysEx",
- "ContentSettings.PermissionActionsInsecureOrigin_MidiSysEx",
+ "Permissions.Action.MidiSysEx",
+ "Permissions.Action.SecureOrigin.MidiSysEx",
+ "Permissions.Action.InsecureOrigin.MidiSysEx",
action);
break;
case CONTENT_SETTINGS_TYPE_PUSH_MESSAGING:
PERMISSION_ACTION_UMA(
secure_origin,
- "ContentSettings.PermissionActions_PushMessaging",
- "ContentSettings.PermissionActionsSecureOrigin_PushMessaging",
- "ContentSettings.PermissionActionsInsecureOrigin_PushMessaging",
+ "Permissions.Action.PushMessaging",
+ "Permissions.Action.SecureOrigin.PushMessaging",
+ "Permissions.Action.InsecureOrigin.PushMessaging",
action);
break;
#if defined(OS_ANDROID) || defined(OS_CHROMEOS)
case CONTENT_SETTINGS_TYPE_PROTECTED_MEDIA_IDENTIFIER:
PERMISSION_ACTION_UMA(
secure_origin,
- "ContentSettings.PermissionActions_ProtectedMedia",
- "ContentSettings.PermissionActionsSecureOrigin_ProtectedMedia",
- "ContentSettings.PermissionActionsInsecureOrigin_ProtectedMedia",
+ "Permissions.Action.ProtectedMedia",
+ "Permissions.Action.SecureOrigin.ProtectedMedia",
+ "Permissions.Action.InsecureOrigin.ProtectedMedia",
action);
break;
#endif
case CONTENT_SETTINGS_TYPE_DURABLE_STORAGE:
PERMISSION_ACTION_UMA(
- secure_origin, "ContentSettings.PermissionActions_DurableStorage",
- "ContentSettings.PermissionActionsSecureOrigin_DurableStorage",
- "ContentSettings.PermissionActionsInsecureOrigin_DurableStorage",
+ secure_origin,
+ "Permissions.Action.DurableStorage",
+ "Permissions.Action.SecureOrigin.DurableStorage",
+ "Permissions.Action.InsecureOrigin.DurableStorage",
action);
break;
case CONTENT_SETTINGS_TYPE_MEDIASTREAM_MIC:
« no previous file with comments | « no previous file | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698