Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issue 1434763002: Reland "Enable 'Browsing data volume counters on Desktop' by default." (Closed)

Created:
5 years, 1 month ago by msramek
Modified:
5 years, 1 month ago
CC:
chromium-reviews, dbeam+watch-options_chromium.org, michaelpg+watch-options_chromium.org, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland "Enable 'Browsing data volume counters on Desktop' by default." This reverts commit 93f190df6d1e0435e535a4336e1fe9035a5c9eb7. The original CL is https://codereview.chromium.org/1413373012/ The revert CL is https://codereview.chromium.org/1423373006/ The problem which caused the revert was the assumption that ProfileSyncService exists, which should be solved by the CL https://codereview.chromium.org/1413373012/ that landed in the meantime. The trybots did not catch it, as this issue was introduced after running git cl try on the original CL but before it landed. BUG=553640 TBR=stevenjb@chromium.org,isherman@chromium.org,dbeam@chromium.org,petermayo@chromium.org,robliao@chromium.org NOTREECHECKS=True NOTRY=True Committed: https://chromium.googlesource.com/chromium/src/+/ca05a1211ac818518364504b0fd73d5c6419aca2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -5 lines) Patch
M chrome/browser/about_flags.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/options/clear_browser_data_handler.cc View 1 chunk +12 lines, -2 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/chrome_switches.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/ca05a1211ac818518364504b0fd73d5c6419aca2 Cr-Commit-Position: refs/heads/master@{#358922}
5 years, 1 month ago (2015-11-10 22:03:21 UTC) #1
msramek
Committed patchset #1 (id:1) manually as ca05a1211ac818518364504b0fd73d5c6419aca2 (presubmit successful).
5 years, 1 month ago (2015-11-10 22:03:52 UTC) #2
Peter Mayo
5 years, 1 month ago (2015-11-10 22:21:12 UTC) #3
Message was sent while issue was closed.
On 2015/11/10 22:03:52, msramek wrote:
> Committed patchset #1 (id:1) manually as
> ca05a1211ac818518364504b0fd73d5c6419aca2 (presubmit successful).

It seems like bad form in general to leave "NOTREECHECKS" and "NOTRY" on reland
CLs.

They broke unexpectedly the first time, and in this case something which affects
success on landing has landed since.

I appreciate that their were a number of try jobs launched successfully, but if
we were that good at predicting interactions we wouldn't need the CQ in the
first place.

Letting the CQ do it's job may slow the change, but should improve the overall
velocity of the project, which is generally more important.

FWIW,
Peter.

Powered by Google App Engine
This is Rietveld 408576698