Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 1423373006: Revert "Enable 'Browsing data volume counters on Desktop' by default." (Closed)

Created:
5 years, 1 month ago by Peter Mayo
Modified:
5 years, 1 month ago
Reviewers:
msramek, robliao
CC:
chromium-reviews, dbeam+watch-options_chromium.org, michaelpg+watch-options_chromium.org, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Enable 'Browsing data volume counters on Desktop' by default." This reverts commit b3f105f17cb6ff224dc8892f2bde7b4cb4b24388. Bisect show it fails for chromeos=1 (static_library) Failed test is here: https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/12407/steps/browser_tests Failed compile is built here: https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Builder/builds/32209 Failed test is GuestModeOptionsBrowserTest.LoadOptionsByURL BUG=553640 TBR=msramek@chromium.org, robliao@chromium.org NOTREECHECKS=True NOTRY=True Committed: https://crrev.com/93f190df6d1e0435e535a4336e1fe9035a5c9eb7 Cr-Commit-Position: refs/heads/master@{#358685}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -21 lines) Patch
M chrome/browser/about_flags.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/webui/options/clear_browser_data_handler.cc View 1 chunk +2 lines, -12 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/chrome_switches.cc View 2 chunks +2 lines, -5 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1423373006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1423373006/1
5 years, 1 month ago (2015-11-09 22:05:54 UTC) #2
robliao
This is the originating rietveld link: https://codereview.chromium.org/1432563002
5 years, 1 month ago (2015-11-09 22:24:12 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-09 22:30:16 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/93f190df6d1e0435e535a4336e1fe9035a5c9eb7 Cr-Commit-Position: refs/heads/master@{#358685}
5 years, 1 month ago (2015-11-09 22:31:21 UTC) #5
msramek
5 years, 1 month ago (2015-11-10 22:01:13 UTC) #6
Message was sent while issue was closed.
On 2015/11/09 22:31:21, commit-bot: I haz the power wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/93f190df6d1e0435e535a4336e1fe9035a5c9eb7
> Cr-Commit-Position: refs/heads/master@{#358685}

Relanding the revert in https://codereview.chromium.org/1434763002/. I believe
that the issue has been solved in another CL, but will watch the build for a
while to make sure.

Powered by Google App Engine
This is Rietveld 408576698