Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1434543003: Merge to XFA: Fix all relative includes to third_party. (Closed)

Created:
5 years, 1 month ago by Lei Zhang
Modified:
5 years, 1 month ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

Merge to XFA: Fix all relative includes to third_party. - In non-standalone builds, use the provided jpeg library. - Run gn format over all the GN files. - Also roll DEPS for buildtools to c2f2598. - And fix XFA's lack of #includes. BUG=541704 R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1425153006 . (cherry picked from commit 34bb6c58fe60206a08dc0a1f37b7cfe83e8c762c) Committed: https://pdfium.googlesource.com/pdfium/+/8241df7edc53b8777e7f71ff379fa53f368c3a28

Patch Set 1 : fix merge, attempt 1 #

Total comments: 3

Patch Set 2 : fix bad merging #

Patch Set 3 : rebase #

Patch Set 4 : Fix XFA #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+175 lines, -144 lines) Patch
M BUILD.gn View 1 2 3 13 chunks +17 lines, -14 lines 0 comments Download
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M build/standalone.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M core/include/fpdfapi/fpdf_module.h View 1 chunk +1 line, -1 line 0 comments Download
M core/include/fpdfapi/fpdf_parser.h View 1 chunk +1 line, -1 line 0 comments Download
M core/include/fpdfapi/fpdf_render.h View 1 chunk +1 line, -1 line 0 comments Download
M core/include/fpdfdoc/fpdf_doc.h View 1 chunk +1 line, -1 line 0 comments Download
M core/include/fxcodec/fx_codec.h View 1 chunk +1 line, -1 line 0 comments Download
M core/include/fxcodec/fx_codec_flate.h View 1 chunk +1 line, -1 line 0 comments Download
M core/include/fxcrt/fx_safe_types.h View 1 chunk +1 line, -1 line 0 comments Download
M core/include/fxcrt/fx_system.h View 1 chunk +1 line, -1 line 0 comments Download
M core/include/fxge/fx_font.h View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_font/ttgsubtable.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M core/src/fpdfapi/fpdf_page/fpdf_page_func.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M core/src/fpdfapi/fpdf_page/pageint.h View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M core/src/fpdfapi/fpdf_render/fpdf_render_loadimage.cpp View 2 chunks +1 line, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_render/render_int.h View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfdoc/doc_annot.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M core/src/fpdfdoc/doc_bookmark.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdftext/fpdf_text.cpp View 2 chunks +1 line, -1 line 0 comments Download
M core/src/fpdftext/fpdf_text_int.cpp View 2 chunks +1 line, -1 line 0 comments Download
M core/src/fxcodec/DEPS View 1 chunk +4 lines, -2 lines 0 comments Download
M core/src/fxcodec/codec/codec_int.h View 1 chunk +2 lines, -2 lines 0 comments Download
M core/src/fxcodec/codec/fx_codec.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxcodec/codec/fx_codec_flate.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M core/src/fxcodec/codec/fx_codec_icc.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxcodec/codec/fx_codec_jpeg.cpp View 1 chunk +7 lines, -1 line 0 comments Download
M core/src/fxcodec/codec/fx_codec_jpx_opj.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M core/src/fxcodec/jbig2/JBig2_Context.h View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxcodec/jbig2/JBig2_GrdProc.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxcodec/jbig2/JBig2_GrrdProc.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxcodec/jbig2/JBig2_GsidProc.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxcodec/jbig2/JBig2_HtrdProc.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxcodec/jbig2/JBig2_PddProc.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxcodec/jbig2/JBig2_SddProc.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M core/src/fxcodec/jbig2/JBig2_SymbolDict.h View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxcodec/jbig2/JBig2_TrdProc.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M core/src/fxcrt/fx_basic_array.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxcrt/fx_basic_bstring.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxcrt/fx_basic_wstring.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxge/agg/include/fx_agg_driver.h View 1 chunk +3 lines, -3 lines 0 comments Download
M core/src/fxge/agg/src/fx_agg_driver.cpp View 1 chunk +10 lines, -9 lines 0 comments Download
M core/src/fxge/freetype/fx_freetype.c View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxge/ge/fx_ge_path.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/include/fsdk_actionhandler.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/include/fsdk_mgr.h View 1 chunk +6 lines, -6 lines 0 comments Download
M fpdfsdk/src/fpdfformfill.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M fpdfsdk/src/fpdfppo.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/fpdfview.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M fpdfsdk/src/fsdk_baseform.cpp View 1 chunk +5 lines, -6 lines 0 comments Download
M fpdfsdk/src/fsdk_mgr.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/javascript/Document.cpp View 2 chunks +1 line, -1 line 0 comments Download
M fpdfsdk/src/javascript/JS_Object.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/javascript/JS_Runtime_Stub.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/javascript/app.cpp View 2 chunks +1 line, -1 line 0 comments Download
M fpdfsdk/src/jsapi/fxjs_v8_embeddertest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M pdfium.gyp View 1 2 6 chunks +8 lines, -10 lines 0 comments Download
M samples/image_diff.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M samples/image_diff_png.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M samples/pdfium_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M samples/samples.gyp View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M testing/embedder_test.h View 1 chunk +1 line, -1 line 0 comments Download
M testing/embedder_test.cpp View 1 chunk +1 line, -1 line 0 comments Download
M testing/test_support.h View 1 chunk +1 line, -2 lines 0 comments Download
M testing/test_support.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/BUILD.gn View 5 chunks +13 lines, -4 lines 0 comments Download
M third_party/lpng_v163/pngstruct.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/third_party.gyp View 1 2 2 chunks +6 lines, -1 line 0 comments Download
M xfa.gyp View 1 2 3 1 chunk +3 lines, -8 lines 2 comments Download
M xfa/include/fxjse/fxjse.h View 1 2 3 5 chunks +15 lines, -7 lines 2 comments Download

Messages

Total messages: 6 (1 generated)
Lei Zhang
Not ready yet. This doesn't build as of patch set 2. Still a WIP, but ...
5 years, 1 month ago (2015-11-06 04:26:32 UTC) #1
Tom Sepez
https://codereview.chromium.org/1434543003/diff/1/samples/BUILD.gn File samples/BUILD.gn (right): https://codereview.chromium.org/1434543003/diff/1/samples/BUILD.gn#newcode39 samples/BUILD.gn:39: # Regardless of whether the library ships against system ...
5 years, 1 month ago (2015-11-06 18:02:11 UTC) #2
Lei Zhang
Ready for review. https://codereview.chromium.org/1434543003/diff/60001/xfa.gyp File xfa.gyp (left): https://codereview.chromium.org/1434543003/diff/60001/xfa.gyp#oldcode14 xfa.gyp:14: 'dependencies': [ I don't think this ...
5 years, 1 month ago (2015-11-06 21:41:14 UTC) #4
Tom Sepez
lgtm https://codereview.chromium.org/1434543003/diff/60001/xfa.gyp File xfa.gyp (left): https://codereview.chromium.org/1434543003/diff/60001/xfa.gyp#oldcode14 xfa.gyp:14: 'dependencies': [ On 2015/11/06 21:41:14, Lei Zhang wrote: ...
5 years, 1 month ago (2015-11-06 22:21:26 UTC) #5
Lei Zhang
5 years, 1 month ago (2015-11-06 22:38:54 UTC) #6
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) manually as
8241df7edc53b8777e7f71ff379fa53f368c3a28 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698