Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: xfa.gyp

Issue 1434543003: Merge to XFA: Fix all relative includes to third_party. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@xfa
Patch Set: Fix XFA Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/third_party.gyp ('k') | xfa/include/fxjse/fxjse.h » ('j') | xfa/include/fxjse/fxjse.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: xfa.gyp
diff --git a/xfa.gyp b/xfa.gyp
index 8302e8d889297b5db6acc33a1cc754e897cb5307..41497f72e6f74b6199558512fadf266795a587e4 100644
--- a/xfa.gyp
+++ b/xfa.gyp
@@ -11,15 +11,10 @@
{
"target_name":"xfa",
"type":"static_library",
- 'dependencies': [
Lei Zhang 2015/11/06 21:41:14 I don't think this should be here. It's all in the
Tom Sepez 2015/11/06 22:21:26 Acknowledged.
- '<(DEPTH)/v8/tools/gyp/v8.gyp:v8',
- ],
- 'export_dependent_settings': [
- '<(DEPTH)/v8/tools/gyp/v8.gyp:v8',
- ],
'include_dirs': [
- '<(DEPTH)/v8',
- '<(DEPTH)/v8/include',
+ # This is implicit in GN.
+ '<(DEPTH)',
+ '.',
'third_party/freetype/include',
'third_party/freetype/include/freetype',
],
« no previous file with comments | « third_party/third_party.gyp ('k') | xfa/include/fxjse/fxjse.h » ('j') | xfa/include/fxjse/fxjse.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698