Fix all relative includes to third_party.

Fix all relative includes to third_party.

- In non-standalone builds, use the provided jpeg library.
- Run gn format over all the GN files.
- Also roll DEPS for buildtools to c2f2598.

BUG=541704
R=tsepez@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/34bb6c58fe60206a08dc0a1f37b7cfe83e8c762c

[Lei Zhang, 2015-11-05 07:48:30]

thestig@chromium.org changed reviewers:
+ tsepez@chromium.org

[Lei Zhang, 2015-11-05 07:48:30]

The non-build files that are interesting are:

core/src/fxcodec/codec/fx_codec_jpeg.cpp
testing/embedder_test.cpp
testing/test_support.cpp
testing/test_support.h


How did we end up here?
- Getting checkdeps to pass on XFA is messy.
-> Need to sanitize #includes
--> Start with master
---> Too much to do at once, how about just third_party?
----> But now PDFium in Chromium uses the wrong libjpeg
-----> Fix libjpeg

- Attempt to write standalone GN build
-> Realize it's too hard, give up
-> Noticed buildtools is out of date
-> Might as well gn format while we are here

[Tom Sepez, 2015-11-05 22:09:27]

https://codereview.chromium.org/1425153006/diff/20001/BUILD.gn
File BUILD.gn (right):

https://codereview.chromium.org/1425153006/diff/20001/BUILD.gn#newcode161
BUILD.gn:161: include_dirs = []
This can be removed entirely?

https://codereview.chromium.org/1425153006/diff/20001/BUILD.gn#newcode414
BUILD.gn:414: include_dirs = []
ditto?

https://codereview.chromium.org/1425153006/diff/20001/BUILD.gn#newcode770
BUILD.gn:770: include_dirs = []
ditto ditto

https://codereview.chromium.org/1425153006/diff/20001/core/include/fpdfapi/fp...
File core/include/fpdfapi/fpdf_module.h (right):

https://codereview.chromium.org/1425153006/diff/20001/core/include/fpdfapi/fp...
core/include/fpdfapi/fpdf_module.h:12: #include
"third_party/base/nonstd_unique_ptr.h"
Ok, is there such a thing under chromium's base?  Will it look there as part of
a chromium build?

[Tom Sepez, 2015-11-05 22:13:07]

Should the description say "to third_party" rather than "in third_party"?

[Lei Zhang, 2015-11-06 00:07:07]

Description was changed from

==========
Fix all relative includes in third_party.

- In non-standalone builds, use the provided jpeg library.
- Run gn format over all the GN files.
- Also roll DEPS for buildtools to c2f2598.

BUG=541704
==========

to

==========
Fix all relative includes to third_party.

- In non-standalone builds, use the provided jpeg library.
- Run gn format over all the GN files.
- Also roll DEPS for buildtools to c2f2598.

BUG=541704
==========

[Lei Zhang, 2015-11-06 00:13:37]

thestig@chromium.org changed reviewers:
+ dpranke@chromium.org

[Lei Zhang, 2015-11-06 00:13:37]

+dpranke for some GN advice.

https://codereview.chromium.org/1425153006/diff/20001/BUILD.gn
File BUILD.gn (right):

https://codereview.chromium.org/1425153006/diff/20001/BUILD.gn#newcode161
BUILD.gn:161: include_dirs = []
On 2015/11/05 22:09:26, Tom Sepez wrote:
> This can be removed entirely?

I think we need this for the include_dirs += [foo] line below.

https://codereview.chromium.org/1425153006/diff/20001/core/include/fpdfapi/fp...
File core/include/fpdfapi/fpdf_module.h (right):

https://codereview.chromium.org/1425153006/diff/20001/core/include/fpdfapi/fp...
core/include/fpdfapi/fpdf_module.h:12: #include
"third_party/base/nonstd_unique_ptr.h"
On 2015/11/05 22:09:26, Tom Sepez wrote:
> Ok, is there such a thing under chromium's base?  Will it look there as part
of
> a chromium build?

There is not such a thing, but it will look there.

[Tom Sepez, 2015-11-06 00:17:19]

lgtm

https://codereview.chromium.org/1425153006/diff/20001/BUILD.gn
File BUILD.gn (right):

https://codereview.chromium.org/1425153006/diff/20001/BUILD.gn#newcode161
BUILD.gn:161: include_dirs = []
On 2015/11/06 00:13:37, Lei Zhang wrote:
> On 2015/11/05 22:09:26, Tom Sepez wrote:
> > This can be removed entirely?
> 
> I think we need this for the include_dirs += [foo] line below.
Yes, you do, I remember getting burned by this before now that you mention it.

[Dirk Pranke, 2015-11-06 00:17:23]

On 2015/11/06 00:13:37, Lei Zhang wrote:
> +dpranke for some GN advice.

Sorry, advice on what?

[Lei Zhang, 2015-11-06 00:18:12]

On 2015/11/06 00:17:23, Dirk Pranke wrote:
> On 2015/11/06 00:13:37, Lei Zhang wrote:
> > +dpranke for some GN advice.
> 
> Sorry, advice on what?

Whether I have to write:

foo = []

if (cond) {
  foo += [qux]
}

or if there's some better way.

[Lei Zhang, 2015-11-06 00:22:13]

On 2015/11/06 00:18:12, Lei Zhang wrote:
> or if there's some better way.

Or just look at the .gn files and say thumbs up/down.

[Dirk Pranke, 2015-11-06 00:30:48]

On 2015/11/06 00:18:12, Lei Zhang wrote:
> On 2015/11/06 00:17:23, Dirk Pranke wrote:
> > On 2015/11/06 00:13:37, Lei Zhang wrote:
> > > +dpranke for some GN advice.
> > 
> > Sorry, advice on what?
> 
> Whether I have to write:
> 
> foo = []
> 
> if (cond) {
>   foo += [qux]
> }
> 
> or if there's some better way.

Nope, that's what you have to do. The GN files looked fine w/ tom's edits.

[Lei Zhang, 2015-11-06 02:39:48]

Committed patchset #3 (id:40001) manually as
34bb6c58fe60206a08dc0a1f37b7cfe83e8c762c (presubmit successful).