Source/core/html/HTMLAllCollection.h - Issue 143453010: Have getElementsByClassName() / getElementsByTagName*() return an HTMLCollection

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLAllCollection.h

Issue 143453010: Have getElementsByClassName() / getElementsByTagName*() return an HTMLCollection (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Null HTMLCollection handling Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/fast/js/getOwnPropertyDescriptor-expected.txt ('K') | « Source/core/html/CollectionType.h ('k') | Source/core/html/HTMLAllCollection.cpp » ('j') | Source/core/html/HTMLAllCollection.idl » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/html/HTMLAllCollection.h

diff --git a/Source/core/html/HTMLAllCollection.h b/Source/core/html/HTMLAllCollection.h

index f6ba13a58e06a641b1e0767cdc39375e1bce2ceb..da418bf582f5c703eabd38cb8f568511d18c6907 100644

--- a/Source/core/html/HTMLAllCollection.h

+++ b/Source/core/html/HTMLAllCollection.h

@@ -37,7 +37,7 @@ public:

Node* namedItemWithIndex(const AtomicString& name, unsigned index) const;

void anonymousNamedGetter(const AtomicString& name, bool&, RefPtr<NodeList>&, bool&, RefPtr<Node>&);

- PassRefPtr<NodeList> tags(const AtomicString&);

+ PassRefPtr<HTMLCollection> tags(const AtomicString&);

private:

HTMLAllCollection(ContainerNode*, CollectionType);