Source/core/html/HTMLAllCollection.cpp - Issue 143453010: Have getElementsByClassName() / getElementsByTagName*() return an HTMLCollection

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLAllCollection.cpp

Issue 143453010: Have getElementsByClassName() / getElementsByTagName*() return an HTMLCollection (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Null HTMLCollection handling Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/fast/js/getOwnPropertyDescriptor-expected.txt ('K') | « Source/core/html/HTMLAllCollection.h ('k') | Source/core/html/HTMLAllCollection.idl » ('j') | Source/core/html/HTMLAllCollection.idl » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/html/HTMLAllCollection.cpp

diff --git a/Source/core/html/HTMLAllCollection.cpp b/Source/core/html/HTMLAllCollection.cpp

index 9af8d2baa13ae08d3af21fe6a94d51334d2ead0e..109bca0291bbc0a4dcef4ba6749bc194541d7e9e 100644

--- a/Source/core/html/HTMLAllCollection.cpp

+++ b/Source/core/html/HTMLAllCollection.cpp

@@ -84,7 +84,7 @@ void HTMLAllCollection::anonymousNamedGetter(const AtomicString& name, bool& ret

returnValue0 = NamedNodesCollection::create(namedItems);

}

-PassRefPtr<NodeList> HTMLAllCollection::tags(const AtomicString& name)

+PassRefPtr<HTMLCollection> HTMLAllCollection::tags(const AtomicString& name)

{

return ownerNode()->getElementsByTagName(name);

}