Source/core/html/HTMLAllCollection.idl - Issue 143453010: Have getElementsByClassName() / getElementsByTagName*() return an HTMLCollection

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLAllCollection.idl

Issue 143453010: Have getElementsByClassName() / getElementsByTagName*() return an HTMLCollection (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Null HTMLCollection handling Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/fast/js/getOwnPropertyDescriptor-expected.txt ('K') | « Source/core/html/HTMLAllCollection.cpp ('k') | Source/core/html/HTMLCollection.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/html/HTMLAllCollection.idl

diff --git a/Source/core/html/HTMLAllCollection.idl b/Source/core/html/HTMLAllCollection.idl

index 861296ce50e37263fe876e561594a4a3e6d7003e..586117e32161ea6286e7889d6bda7ca2a4ec2cd7 100644

--- a/Source/core/html/HTMLAllCollection.idl

+++ b/Source/core/html/HTMLAllCollection.idl

@@ -33,6 +33,5 @@

[Custom] Node item([Default=Undefined] optional unsigned long index);

[NotEnumerable] getter (NodeList or Node) (DOMString name);

[Custom] Node namedItem(DOMString name);

- // FIXME: This should return an HTMLAllCollection.

arv (Not doing code reviews) 2014/01/29 04:45:48 This FIXME seems to still apply. http://www.whatw

Inactive 2014/01/29 14:08:14 My bad, I misread the comment. I will reintroduce

Inactive 2014/01/29 16:21:34 Done.

- [MeasureAs=DocumentAllTags] NodeList tags(DOMString name);

+ [MeasureAs=DocumentAllTags] HTMLCollection tags(DOMString name);

};

« LayoutTests/fast/js/getOwnPropertyDescriptor-expected.txt ('K') | « Source/core/html/HTMLAllCollection.cpp ('k') | Source/core/html/HTMLCollection.cpp » ('j') | no next file with comments »