Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1434223002: Remove relative includes. (Closed)

Created:
5 years, 1 month ago by Lei Zhang
Modified:
5 years, 1 month ago
Reviewers:
dsinclair
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove relative includes. That refer to parent directories. R=dsinclair@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/22bc4227fbbda5a5e9abad2a2c0a98c04fe7f228

Patch Set 1 #

Total comments: 8

Patch Set 2 : sort #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+335 lines, -338 lines) Patch
M core/include/fdrm/fx_crypt.h View 1 chunk +1 line, -1 line 0 comments Download
M core/include/fpdfapi/fpdf_module.h View 1 chunk +2 lines, -2 lines 0 comments Download
M core/include/fpdfapi/fpdf_objects.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M core/include/fpdfapi/fpdf_page.h View 1 chunk +1 line, -1 line 0 comments Download
M core/include/fpdfapi/fpdf_pageobj.h View 1 chunk +1 line, -1 line 0 comments Download
M core/include/fpdfapi/fpdf_parser.h View 1 chunk +1 line, -1 line 0 comments Download
M core/include/fpdfapi/fpdf_render.h View 1 chunk +1 line, -1 line 0 comments Download
M core/include/fpdfapi/fpdf_resource.h View 1 chunk +2 lines, -2 lines 0 comments Download
M core/include/fpdfapi/fpdfapi.h View 1 chunk +1 line, -1 line 0 comments Download
M core/include/fpdfdoc/fpdf_ap.h View 1 chunk +1 line, -1 line 0 comments Download
M core/include/fpdfdoc/fpdf_doc.h View 1 chunk +2 lines, -2 lines 0 comments Download
M core/include/fpdfdoc/fpdf_vt.h View 1 chunk +2 lines, -2 lines 0 comments Download
M core/include/fpdftext/fpdf_text.h View 1 chunk +1 line, -1 line 0 comments Download
M core/include/fxcodec/fx_codec.h View 1 chunk +1 line, -1 line 0 comments Download
M core/include/fxge/fpf.h View 1 chunk +1 line, -1 line 0 comments Download
M core/include/fxge/fx_dib.h View 1 chunk +2 lines, -2 lines 0 comments Download
M core/include/fxge/fx_font.h View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_cmaps/CNS1/cmaps_cns1.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M core/src/fpdfapi/fpdf_cmaps/GB1/cmaps_gb1.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M core/src/fpdfapi/fpdf_cmaps/Japan1/cmaps_japan1.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M core/src/fpdfapi/fpdf_cmaps/Korea1/cmaps_korea1.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M core/src/fpdfapi/fpdf_cmaps/fpdf_cmaps.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_edit/fpdf_edit_content.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_edit/fpdf_edit_doc.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_edit/fpdf_edit_image.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M core/src/fpdfapi/fpdf_font/fpdf_font.cpp View 2 chunks +5 lines, -4 lines 0 comments Download
M core/src/fpdfapi/fpdf_font/fpdf_font_cid.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_page/fpdf_page_doc.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_page/fpdf_page_graph_state.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_parser/fpdf_parser_decode_embeddertest.cpp View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_render/fpdf_render.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_render/fpdf_render_cache.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_render/fpdf_render_image.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_render/fpdf_render_loadimage.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_render/fpdf_render_pattern.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_render/fpdf_render_text.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxcodec/codec/codec_int.h View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxcodec/codec/fx_codec_jpx_unittest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxcrt/fx_basic_bstring_unittest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxcrt/fx_basic_wstring_unittest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxcrt/fx_system_unittest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxge/agg/src/fx_agg_driver.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M core/src/fxge/apple/fx_apple_platform.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M core/src/fxge/apple/fx_quartz_device.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M core/src/fxge/ge/fx_ge_fontmap.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxge/win32/fx_win32_device.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M core/src/fxge/win32/fx_win32_print.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/include/formfiller/FFL_CBA_Fontmap.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/include/formfiller/FormFiller.h View 1 chunk +3 lines, -3 lines 0 comments Download
M fpdfsdk/include/fxedit/fxet_stub.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/include/pdfwindow/PDFWindow.h View 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/include/pdfwindow/PWL_EditCtrl.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/include/pdfwindow/PWL_FontMap.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/include/pdfwindow/PWL_ListBox.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/include/pdfwindow/PWL_Utils.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/include/pdfwindow/PWL_Wnd.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/formfiller/FFL_CBA_Fontmap.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/src/formfiller/FFL_CheckBox.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M fpdfsdk/src/formfiller/FFL_ComboBox.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
M fpdfsdk/src/formfiller/FFL_FormFiller.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/src/formfiller/FFL_IFormFiller.cpp View 1 chunk +8 lines, -8 lines 0 comments Download
M fpdfsdk/src/formfiller/FFL_ListBox.cpp View 1 chunk +5 lines, -7 lines 0 comments Download
M fpdfsdk/src/formfiller/FFL_PushButton.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M fpdfsdk/src/formfiller/FFL_RadioButton.cpp View 1 chunk +3 lines, -4 lines 0 comments Download
M fpdfsdk/src/formfiller/FFL_TextField.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/src/fpdf_dataavail.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/fpdf_ext.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/fpdf_flatten.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/fpdf_progressive.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/src/fpdf_sysfontinfo.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/src/fpdf_transformpage.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/fpdfdoc.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/fpdfeditimg.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/fpdfeditpage.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/fpdfformfill.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/src/fpdfppo.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/fpdfsave.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/fpdftext.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/fpdfview.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M fpdfsdk/src/fsdk_actionhandler.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M fpdfsdk/src/fsdk_annothandler.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M fpdfsdk/src/fsdk_baseannot.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M fpdfsdk/src/fsdk_baseform.cpp View 1 chunk +7 lines, -8 lines 0 comments Download
M fpdfsdk/src/fsdk_mgr.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M fpdfsdk/src/fsdk_rendercontext.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/fxedit/fxet_ap.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M fpdfsdk/src/fxedit/fxet_edit.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/src/fxedit/fxet_list.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M fpdfsdk/src/fxedit/fxet_module.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M fpdfsdk/src/fxedit/fxet_pageobjs.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M fpdfsdk/src/javascript/Consts.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/javascript/Document.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M fpdfsdk/src/javascript/Field.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/javascript/Field.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M fpdfsdk/src/javascript/Icon.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/javascript/JS_Context.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/javascript/JS_Context.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/javascript/JS_Define.h View 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/src/javascript/JS_EventHandler.cpp View 2 chunks +1 line, -1 line 0 comments Download
M fpdfsdk/src/javascript/JS_GlobalData.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/javascript/JS_Object.h View 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/src/javascript/JS_Object.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/src/javascript/JS_Runtime.h View 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/src/javascript/JS_Runtime.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M fpdfsdk/src/javascript/JS_Runtime_Stub.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/src/javascript/JS_Value.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/javascript/PublicMethods.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M fpdfsdk/src/javascript/app.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M fpdfsdk/src/javascript/color.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/javascript/color.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M fpdfsdk/src/javascript/console.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M fpdfsdk/src/javascript/event.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M fpdfsdk/src/javascript/global.cpp View 2 chunks +1 line, -1 line 0 comments Download
M fpdfsdk/src/javascript/report.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/javascript/resource.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/javascript/util.cpp View 2 chunks +1 line, -1 line 0 comments Download
M fpdfsdk/src/jsapi/fxjs_v8.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/jsapi/fxjs_v8_embeddertest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/src/pdfwindow/PWL_Button.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M fpdfsdk/src/pdfwindow/PWL_Caret.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M fpdfsdk/src/pdfwindow/PWL_ComboBox.cpp View 1 chunk +7 lines, -7 lines 0 comments Download
M fpdfsdk/src/pdfwindow/PWL_Edit.cpp View 1 chunk +8 lines, -8 lines 0 comments Download
M fpdfsdk/src/pdfwindow/PWL_EditCtrl.cpp View 1 chunk +7 lines, -7 lines 0 comments Download
M fpdfsdk/src/pdfwindow/PWL_FontMap.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M fpdfsdk/src/pdfwindow/PWL_Icon.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M fpdfsdk/src/pdfwindow/PWL_IconList.cpp View 1 chunk +7 lines, -7 lines 0 comments Download
M fpdfsdk/src/pdfwindow/PWL_Label.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M fpdfsdk/src/pdfwindow/PWL_ListBox.cpp View 1 chunk +7 lines, -7 lines 0 comments Download
M fpdfsdk/src/pdfwindow/PWL_ListCtrl.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M fpdfsdk/src/pdfwindow/PWL_Note.cpp View 1 chunk +13 lines, -13 lines 0 comments Download
M fpdfsdk/src/pdfwindow/PWL_ScrollBar.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M fpdfsdk/src/pdfwindow/PWL_Signature.cpp View 1 chunk +6 lines, -6 lines 0 comments Download
M fpdfsdk/src/pdfwindow/PWL_SpecialButton.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
M fpdfsdk/src/pdfwindow/PWL_Utils.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M fpdfsdk/src/pdfwindow/PWL_Wnd.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M samples/fx_lpng/include/fx_png.h View 1 chunk +1 line, -1 line 0 comments Download
M samples/fx_lpng/src/fx_png.c View 1 chunk +1 line, -1 line 0 comments Download
M samples/fx_lpng/src/fx_pngerror.c View 1 chunk +1 line, -1 line 0 comments Download
M samples/fx_lpng/src/fx_pngget.c View 1 chunk +1 line, -1 line 0 comments Download
M samples/fx_lpng/src/fx_pngmem.c View 1 chunk +1 line, -1 line 0 comments Download
M samples/fx_lpng/src/fx_pngpread.c View 1 chunk +1 line, -1 line 0 comments Download
M samples/fx_lpng/src/fx_pngread.c View 1 chunk +1 line, -1 line 0 comments Download
M samples/fx_lpng/src/fx_pngrio.c View 1 chunk +1 line, -1 line 0 comments Download
M samples/fx_lpng/src/fx_pngrtran.c View 1 chunk +1 line, -1 line 0 comments Download
M samples/fx_lpng/src/fx_pngrutil.c View 1 chunk +1 line, -1 line 0 comments Download
M samples/fx_lpng/src/fx_pngset.c View 1 chunk +1 line, -1 line 0 comments Download
M samples/fx_lpng/src/fx_pngtrans.c View 1 chunk +1 line, -1 line 0 comments Download
M samples/fx_lpng/src/fx_pngwio.c View 1 chunk +1 line, -1 line 0 comments Download
M samples/fx_lpng/src/fx_pngwrite.c View 1 chunk +1 line, -1 line 0 comments Download
M samples/fx_lpng/src/fx_pngwtran.c View 1 chunk +1 line, -1 line 0 comments Download
M samples/fx_lpng/src/fx_pngwutil.c View 1 chunk +1 line, -1 line 0 comments Download
M samples/pdfium_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/base/numerics/safe_conversions.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/base/numerics/safe_conversions_impl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/base/numerics/safe_math_impl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/lcms2-2.6/src/lcms2_internal.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Lei Zhang
wee!
5 years, 1 month ago (2015-11-12 09:31:34 UTC) #2
dsinclair
lgtm w/ nits and a question. https://codereview.chromium.org/1434223002/diff/1/core/src/fpdfapi/fpdf_cmaps/CNS1/cmaps_cns1.cpp File core/src/fpdfapi/fpdf_cmaps/CNS1/cmaps_cns1.cpp (right): https://codereview.chromium.org/1434223002/diff/1/core/src/fpdfapi/fpdf_cmaps/CNS1/cmaps_cns1.cpp#newcode13 core/src/fpdfapi/fpdf_cmaps/CNS1/cmaps_cns1.cpp:13: #include "core/src/fpdfapi/fpdf_cmaps/cmap_int.h" sort ...
5 years, 1 month ago (2015-11-12 16:28:39 UTC) #4
Lei Zhang
Sorted. I thought I sorted them all previously but guess not. https://codereview.chromium.org/1434223002/diff/1/third_party/lcms2-2.6/src/lcms2_internal.h File third_party/lcms2-2.6/src/lcms2_internal.h (right): ...
5 years, 1 month ago (2015-11-13 05:15:17 UTC) #5
Lei Zhang
5 years, 1 month ago (2015-11-13 05:17:49 UTC) #6
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
22bc4227fbbda5a5e9abad2a2c0a98c04fe7f228 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698