Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Unified Diff: sql/connection.h

Issue 1434173003: [sql] Differentiate compile errors from regular errors. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | sql/connection.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sql/connection.h
diff --git a/sql/connection.h b/sql/connection.h
index 4e3ce261d8e37f7a0044fe7d0445b50e5207ef08..5b219dbde744e63c35fd5b5009be06196d174033 100644
--- a/sql/connection.h
+++ b/sql/connection.h
@@ -466,6 +466,10 @@ class SQL_EXPORT Connection : public base::trace_event::MemoryDumpProvider {
// tests.
static bool ShouldIgnoreSqliteError(int error);
+ // Additionally ignores errors which are unlikely to be caused by problems
+ // with the syntax of a SQL statement, or problems with the database schema.
+ static bool ShouldIgnoreSqliteCompileError(int error);
+
// base::trace_event::MemoryDumpProvider implementation.
bool OnMemoryDump(
const base::trace_event::MemoryDumpArgs& args,
« no previous file with comments | « no previous file | sql/connection.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698