Customize login test utils to wait for cookies to be set.

Customize login test utils to wait for cookies to be set.

The CL also allows customizing the sigin source enum. This allows
implementing different signin flow cases.

BUG=552505
Committed: https://crrev.com/145678a47c85d059f7197c82da241b08daa221f5
Cr-Commit-Position: refs/heads/master@{#358728}

[shadi1, 2015-11-06 19:42:23]

Description was changed from

==========
Customize login test utils to wait for cookies to be set.

The CL also allows customizing the sigin source enum. This allows
implementing different signin flow cases.

BUG=552505
==========

to

==========
Customize login test utils to wait for cookies to be set.

The CL also allows customizing the sigin source enum. This allows
implementing different signin flow cases.

BUG=552505
==========

[shadi1, 2015-11-06 19:42:23]

shadi@google.com changed reviewers:
+ rogerta@chromium.org

[shadi1, 2015-11-06 19:42:35]

shadi@google.com changed reviewers:
+ shadi@google.com

[shadi1, 2015-11-06 19:42:35]

PTAL

[Roger Tawa OOO till Jul 10th, 2015-11-09 19:34:20]

lgtm

https://codereview.chromium.org/1433613002/diff/1/chrome/browser/ui/webui/sig...
File chrome/browser/ui/webui/signin/login_ui_test_utils.cc (right):

https://codereview.chromium.org/1433613002/diff/1/chrome/browser/ui/webui/sig...
chrome/browser/ui/webui/signin/login_ui_test_utils.cc:92: // By default, we only
wait until SigninSuccess event is fired which happens
Nit: there is no default really, since callers must always specify whether to
wait or not in the ctor.  So maybe replace:

  By default  --> If false

[shadi, 2015-11-10 00:13:58]

The CQ bit was checked by shadi@chromium.org

[shadi, 2015-11-10 00:13:58]

The patchset sent to the CQ was uploaded after l-g-t-m from rogerta@chromium.org
Link to the patchset: https://codereview.chromium.org/1433613002/#ps20001
(title: "nit: docs")

[commit-bot: I haz the power, 2015-11-10 00:16:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1433613002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1433613002/20001

[commit-bot: I haz the power, 2015-11-10 01:26:06]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-11-10 01:26:57]

Patchset 2 (id:??) landed as
https://crrev.com/145678a47c85d059f7197c82da241b08daa221f5
Cr-Commit-Position: refs/heads/master@{#358728}