Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8007)

Unified Diff: chrome/browser/ui/webui/signin/login_ui_test_utils.h

Issue 1433613002: Customize login test utils to wait for cookies to be set. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: nit: docs Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/webui/signin/login_ui_test_utils.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/signin/login_ui_test_utils.h
diff --git a/chrome/browser/ui/webui/signin/login_ui_test_utils.h b/chrome/browser/ui/webui/signin/login_ui_test_utils.h
index bf9a11051041af161ad1597ee3b8be20de348c58..acddd3934aeb888109aae6ad4c13d116a4c5993c 100644
--- a/chrome/browser/ui/webui/signin/login_ui_test_utils.h
+++ b/chrome/browser/ui/webui/signin/login_ui_test_utils.h
@@ -7,6 +7,8 @@
#include <string>
+#include "components/signin/core/browser/signin_metrics.h"
+
class Browser;
namespace login_ui_test_utils {
@@ -41,6 +43,17 @@ void SigninInOldGaiaFlow(Browser* browser,
// A function to sign in a user using Chrome sign-in UI interface.
// This will block until a signin succeeded or failed notification is observed.
+// In case |wait_for_account_cookies|, the call will block until the account
+// cookies have been written to the cookie jar.
+// |signin_source| identifies the source used to load the signin page.
+bool SignInWithUI(Browser* browser,
+ const std::string& email,
+ const std::string& password,
+ bool wait_for_account_cookies,
+ signin_metrics::Source signin_source);
+
+// Most common way to sign in a user, it does not wait for cookies to be set
+// and uses the SOURCE_START_PAGE as signin source.
bool SignInWithUI(Browser* browser,
const std::string& email,
const std::string& password);
« no previous file with comments | « no previous file | chrome/browser/ui/webui/signin/login_ui_test_utils.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698