[page_load_metrics] Get navigation_start from NavigationHandle

[page_load_metrics] Get navigation_start from NavigationHandle

This change also exposes GetNavigationStart() to the public content interface, with PageLoadTracker as the first consumer.

This gives us much better resolution time for events logged relative to
navigation start on the browser side (backgrounding, etc.)

This change is needed to implement abort timing.
BUG=517209
Committed: https://crrev.com/54a2332a8a1f5299329c445f126ccbd2c7e1fef8
Cr-Commit-Position: refs/heads/master@{#360084}

[Charlie Harrison, 2015-11-06 22:45:01]

Description was changed from

==========
[page_load_metrics] Get navigation_start from NavigationHandle
This gives us much better resolution time for events logged relative to
navigation start on the browser side (backgrounding, etc.)
This change is needed to implement abort timing.
BUG=517209
==========

to

==========
[page_load_metrics] Get navigation_start from NavigationHandle

This change also exposes GetNavigationStart() to the public content interface,
with PageLoadTracker as the first consumer.

This gives us much better resolution time for events logged relative to
navigation start on the browser side (backgrounding, etc.)

This change is needed to implement abort timing.
BUG=517209
==========

[Charlie Harrison, 2015-11-06 22:45:01]

csharrison@chromium.org changed reviewers:
+ clamy@chromium.org, kinuko@chromium.org

[Charlie Harrison, 2015-11-06 23:03:36]

PTAL. Thanks!

[clamy, 2015-11-09 13:09:53]

content/ part looks good, I will wait for nasko's review on the other CL before
finishing this one.

https://codereview.chromium.org/1433533007/diff/20001/content/public/browser/...
File content/public/browser/navigation_handle.h (right):

https://codereview.chromium.org/1433533007/diff/20001/content/public/browser/...
content/public/browser/navigation_handle.h:42: // The time the navigation
started, recorded either in the renderer or browser
nit: in the browser process...

https://codereview.chromium.org/1433533007/diff/20001/content/public/browser/...
content/public/browser/navigation_handle.h:43: // process. Corresponds to
Navigation Timing API Standard.
nit: the Navigation Timing API Standard?

[Charlie Harrison, 2015-11-09 18:45:10]

https://codereview.chromium.org/1433533007/diff/20001/content/public/browser/...
File content/public/browser/navigation_handle.h (right):

https://codereview.chromium.org/1433533007/diff/20001/content/public/browser/...
content/public/browser/navigation_handle.h:42: // The time the navigation
started, recorded either in the renderer or browser
On 2015/11/09 13:09:53, clamy wrote:
> nit: in the browser process...

Can you clarify this comment?

https://codereview.chromium.org/1433533007/diff/20001/content/public/browser/...
content/public/browser/navigation_handle.h:43: // process. Corresponds to
Navigation Timing API Standard.
On 2015/11/09 13:09:53, clamy wrote:
> nit: the Navigation Timing API Standard?

Done.

[Charlie Harrison, 2015-11-09 21:57:27]

csharrison@chromium.org changed reviewers:
+ bmcquade@chromium.org

[Bryan McQuade, 2015-11-11 13:44:54]

lgtm

[kinuko, 2015-11-12 20:35:11]

The new patch set (for the comments fix) is not uploaded yet?

The change itself lgtm (assuming the other CL will get stamped too)

https://codereview.chromium.org/1433533007/diff/20001/content/public/browser/...
File content/public/browser/navigation_handle.h (right):

https://codereview.chromium.org/1433533007/diff/20001/content/public/browser/...
content/public/browser/navigation_handle.h:42: // The time the navigation
started, recorded either in the renderer or browser
On 2015/11/09 18:45:10, csharrison wrote:
> On 2015/11/09 13:09:53, clamy wrote:
> > nit: in the browser process...
> 
> Can you clarify this comment?

"... in the renderer or in the browser process" I guess.

[Charlie Harrison, 2015-11-12 20:48:49]

kinuko@ Updated comments, thanks!

[Charlie Harrison, 2015-11-17 00:54:00]

On 2015/11/12 20:48:49, csharrison wrote:
> kinuko@ Updated comments, thanks!

clamy@ This got a minor makeover with nasko's review of the other CL. PTAL
thanks!

[clamy, 2015-11-17 12:52:31]

Thanks! Once the naming is changed it will be fine.

https://codereview.chromium.org/1433533007/diff/100001/content/public/browser...
File content/public/browser/navigation_handle.h (right):

https://codereview.chromium.org/1433533007/diff/100001/content/public/browser...
content/public/browser/navigation_handle.h:44: virtual const base::TimeTicks&
navigation_start() = 0;
This should be called NavigationStart instead of navigation_start.

[Charlie Harrison, 2015-11-17 14:47:32]

Updated, thanks!

https://codereview.chromium.org/1433533007/diff/100001/content/public/browser...
File content/public/browser/navigation_handle.h (right):

https://codereview.chromium.org/1433533007/diff/100001/content/public/browser...
content/public/browser/navigation_handle.h:44: virtual const base::TimeTicks&
navigation_start() = 0;
On 2015/11/17 12:52:31, clamy wrote:
> This should be called NavigationStart instead of navigation_start.

Ah, okay. In that case I'll need to change it in the impl as well. Nasko wanted
it hacker_case, but I guess now that it's virtual it shouldn't be.

[clamy, 2015-11-17 14:49:56]

Thanks! content/ lgtm.

[Charlie Harrison, 2015-11-17 14:55:50]

The CQ bit was checked by csharrison@chromium.org

[Charlie Harrison, 2015-11-17 14:55:50]

The patchset sent to the CQ was uploaded after l-g-t-m from kinuko@chromium.org,
bmcquade@chromium.org
Link to the patchset: https://codereview.chromium.org/1433533007/#ps120001
(title: "navigation_start => NavigationStart")

[commit-bot: I haz the power, 2015-11-17 14:56:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1433533007/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1433533007/120001

[commit-bot: I haz the power, 2015-11-17 16:22:14]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2015-11-17 16:23:54]

Patchset 7 (id:??) landed as
https://crrev.com/54a2332a8a1f5299329c445f126ccbd2c7e1fef8
Cr-Commit-Position: refs/heads/master@{#360084}