Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1340)

Unified Diff: content/browser/frame_host/navigation_handle_impl.h

Issue 1433533007: [page_load_metrics] Get navigation_start from NavigationHandle (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@change-names-refactor
Patch Set: navigation_start => NavigationStart Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/navigation_handle_impl.h
diff --git a/content/browser/frame_host/navigation_handle_impl.h b/content/browser/frame_host/navigation_handle_impl.h
index b0a7b9a36008a11a40eeaca47a28970b330fa8a9..004cf8220eea4fb0252873df2a8749881de87cea 100644
--- a/content/browser/frame_host/navigation_handle_impl.h
+++ b/content/browser/frame_host/navigation_handle_impl.h
@@ -70,6 +70,7 @@ class CONTENT_EXPORT NavigationHandleImpl : public NavigationHandle {
// NavigationHandle implementation:
const GURL& GetURL() override;
bool IsInMainFrame() override;
+ const base::TimeTicks& NavigationStart() override;
bool IsPost() override;
const Referrer& GetReferrer() override;
bool HasUserGesture() override;
@@ -95,11 +96,6 @@ class CONTENT_EXPORT NavigationHandleImpl : public NavigationHandle {
const GURL& new_referrer_url,
bool new_is_external_protocol) override;
- // The time the navigation started, recorded either in the renderer or browser
- // process. Corresponds to Navigation Timing API.
- // TODO(csharrison): Add this to the public class and mark this override.
- const base::TimeTicks& navigation_start() { return navigation_start_; }
-
NavigatorDelegate* GetDelegate() const;
void set_net_error_code(net::Error net_error_code) {

Powered by Google App Engine
This is Rietveld 408576698