Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Side by Side Diff: content/public/browser/navigation_handle.h

Issue 1433533007: [page_load_metrics] Get navigation_start from NavigationHandle (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@change-names-refactor
Patch Set: Update dependent patchset Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « content/browser/frame_host/navigation_handle_impl.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_PUBLIC_BROWSER_NAVIGATION_HANDLE_H_ 5 #ifndef CONTENT_PUBLIC_BROWSER_NAVIGATION_HANDLE_H_
6 #define CONTENT_PUBLIC_BROWSER_NAVIGATION_HANDLE_H_ 6 #define CONTENT_PUBLIC_BROWSER_NAVIGATION_HANDLE_H_
7 7
8 #include "content/common/content_export.h" 8 #include "content/common/content_export.h"
9 #include "content/public/browser/navigation_throttle.h" 9 #include "content/public/browser/navigation_throttle.h"
10 #include "content/public/common/referrer.h" 10 #include "content/public/common/referrer.h"
(...skipping 21 matching lines...) Expand all
32 // when encountering a server redirect. 32 // when encountering a server redirect.
33 virtual const GURL& GetURL() = 0; 33 virtual const GURL& GetURL() = 0;
34 34
35 // Whether the navigation is taking place in the main frame or in a subframe. 35 // Whether the navigation is taking place in the main frame or in a subframe.
36 // This remains constant over the navigation lifetime. 36 // This remains constant over the navigation lifetime.
37 virtual bool IsInMainFrame() = 0; 37 virtual bool IsInMainFrame() = 0;
38 38
39 // The WebContents the navigation is taking place in. 39 // The WebContents the navigation is taking place in.
40 WebContents* GetWebContents(); 40 WebContents* GetWebContents();
41 41
42 // The time the navigation started, recorded either in the renderer or browser
clamy 2015/11/09 13:09:53 nit: in the browser process...
Charlie Harrison 2015/11/09 18:45:10 Can you clarify this comment?
kinuko 2015/11/12 20:35:11 "... in the renderer or in the browser process" I
43 // process. Corresponds to Navigation Timing API Standard.
clamy 2015/11/09 13:09:53 nit: the Navigation Timing API Standard?
Charlie Harrison 2015/11/09 18:45:10 Done.
44 virtual const base::TimeTicks& GetNavigationStart() = 0;
45
42 // Parameters available at network request start time ------------------------ 46 // Parameters available at network request start time ------------------------
43 // 47 //
44 // The following parameters are only available when the network request is 48 // The following parameters are only available when the network request is
45 // made for the navigation (or at commit time if no network request is made). 49 // made for the navigation (or at commit time if no network request is made).
46 // This corresponds to NavigationThrottle::WillSendRequest. They should not 50 // This corresponds to NavigationThrottle::WillSendRequest. They should not
47 // be queried before that. 51 // be queried before that.
48 52
49 // Whether the navigation is a POST or a GET. This may change during the 53 // Whether the navigation is a POST or a GET. This may change during the
50 // navigation when encountering a server redirect. 54 // navigation when encountering a server redirect.
51 virtual bool IsPost() = 0; 55 virtual bool IsPost() = 0;
(...skipping 71 matching lines...) Expand 10 before | Expand all | Expand 10 after
123 virtual NavigationThrottle::ThrottleCheckResult 127 virtual NavigationThrottle::ThrottleCheckResult
124 CallWillRedirectRequestForTesting(const GURL& new_url, 128 CallWillRedirectRequestForTesting(const GURL& new_url,
125 bool new_method_is_post, 129 bool new_method_is_post,
126 const GURL& new_referrer_url, 130 const GURL& new_referrer_url,
127 bool new_is_external_protocol) = 0; 131 bool new_is_external_protocol) = 0;
128 }; 132 };
129 133
130 } // namespace content 134 } // namespace content
131 135
132 #endif // CONTENT_PUBLIC_BROWSER_NAVIGATION_HANDLE_H_ 136 #endif // CONTENT_PUBLIC_BROWSER_NAVIGATION_HANDLE_H_
OLDNEW
« no previous file with comments | « content/browser/frame_host/navigation_handle_impl.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698