tracing/tracing/extras/importer/android/event_log_importer.html - Issue 1432973005: Prevent EventLogImporter from matching its own file in vulcanized traces

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tracing/tracing/extras/importer/android/event_log_importer.html

Issue 1432973005: Prevent EventLogImporter from matching its own file in vulcanized traces (Closed) Base URL: git@github.com:catapult-project/catapult.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tracing/tracing/extras/importer/android/event_log_importer.html

diff --git a/tracing/tracing/extras/importer/android/event_log_importer.html b/tracing/tracing/extras/importer/android/event_log_importer.html

index 2c06113243280f69b940ac53bf42bce6afc9a43f..a80852ab1407d8a55858ade20b06f885fbb0d1b4 100644

--- a/tracing/tracing/extras/importer/android/event_log_importer.html

+++ b/tracing/tracing/extras/importer/android/event_log_importer.html

@@ -93,6 +93,10 @@ tr.exportTo('tr.e.importer.android', function() {

if (!(typeof(events) === 'string' || events instanceof String))

return false;

+ // Prevent the importer from matching this file in vulcanized traces.

+ if (/^<!DOCTYPE html>/.test(events))

+ return false;

return eventLogActivityRE.test(events);

};

« no previous file with comments | « no previous file | no next file » | no next file with comments »