Adding a minimize function for clicks on launcher items if only a single item (already active) is a…

This CL is adding a minimize function for clicks on launcher items if only a single item (already active) is associated with it. This is done to avoid that the user clicks and nothing happens (and people expect it to do that). The feature is guarded by a flag.

If the minimize action is not wanted, we use a bouncing animation which gives the user at least some feedback that he has done something.

BUG=231663
TEST=unittest & visual

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195362

[Mr4D (OOO till 08-26), 2013-04-19 01:57:50]

Please have a look!

[James Cook, 2013-04-19 17:57:03]

LGTM with nits

https://codereview.chromium.org/14328031/diff/10003/chrome/app/generated_reso...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/14328031/diff/10003/chrome/app/generated_reso...
chrome/app/generated_resources.grd:6890: +        Disallow launcher to minimize
windows upon item click under certain conditions.
Can you use a shorter string? Something like "Disallow launcher
minimize-on-click"?  Also, no "." at end.

Finally, I would be OK with just adding this feature and not adding a flag.  I
think most of the argument was about *what* should happen when you click in
these situations - I doubt any user is going to want to go back to doing
nothing.

I'm OK with or without a flag - up to you.

https://codereview.chromium.org/14328031/diff/10003/chrome/browser/about_flag...
File chrome/browser/about_flags.cc (right):

https://codereview.chromium.org/14328031/diff/10003/chrome/browser/about_flag...
chrome/browser/about_flags.cc:962:
"disable-Minimize-on-second-launcher-item-click",
"Minimize" -> "minimize".  I don't think it matters, but none of the other items
here use capital letters.

[Mr4D (OOO till 08-26), 2013-04-19 19:04:18]

Addressed. Please have another look!

https://codereview.chromium.org/14328031/diff/10003/chrome/app/generated_reso...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/14328031/diff/10003/chrome/app/generated_reso...
chrome/app/generated_resources.grd:6890: +        Disallow launcher to minimize
windows upon item click under certain conditions.
On 2013/04/19 17:57:03, James Cook (Chromium) wrote:
> Can you use a shorter string? Something like "Disallow launcher
> minimize-on-click"?  Also, no "." at end.
> 
> Finally, I would be OK with just adding this feature and not adding a flag.  I
> think most of the argument was about *what* should happen when you click in
> these situations - I doubt any user is going to want to go back to doing
> nothing.
> 
> I'm OK with or without a flag - up to you.

Done. For the flag: Alex was asking for it after discussing with alcor. Also - I
added the bouncing behavior if turned off - so there should be no "no action"
anymore.

[James Cook, 2013-04-19 19:12:49]

LGTM.  Didn't know Alex wanted a flag - that's fine with me.  Thanks for adding
tests!

[commit-bot: I haz the power, 2013-04-19 19:16:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/skuhne@chromium.org/14328031/1014

[commit-bot: I haz the power, 2013-04-20 01:16:00]

Change committed as 195362