chrome/browser/ui/ash/launcher/chrome_launcher_controller_per_browser.cc - Issue 14328031: Adding a minimize function for clicks on launcher items if only a single item (already active) is a…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/ash/launcher/chrome_launcher_controller_per_browser.cc

Issue 14328031: Adding a minimize function for clicks on launcher items if only a single item (already active) is a… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Added one unit test and addressed comments Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/ash/launcher/chrome_launcher_controller_per_browser.h ('k') | chrome/browser/ui/ash/launcher/shell_window_launcher_item_controller.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/ash/launcher/chrome_launcher_controller_per_browser.cc

diff --git a/chrome/browser/ui/ash/launcher/chrome_launcher_controller_per_browser.cc b/chrome/browser/ui/ash/launcher/chrome_launcher_controller_per_browser.cc

index 649d38bc4edea7bc37c5ce9453cc42ec892afefe..f2387f24c7462e5a1af721e82a660bdcba1a2fa7 100644

--- a/chrome/browser/ui/ash/launcher/chrome_launcher_controller_per_browser.cc

+++ b/chrome/browser/ui/ash/launcher/chrome_launcher_controller_per_browser.cc

@@ -853,6 +853,13 @@ const Extension* ChromeLauncherControllerPerBrowser::GetExtensionForAppID(

return profile_->GetExtensionService()->GetInstalledExtension(app_id);

}

+void ChromeLauncherControllerPerBrowser::ActivateWindowOrMinimizeIfActive(

+ BaseWindow* window,

+ bool allow_minimize) {

+ window->Show();

+ window->Activate();

void ChromeLauncherControllerPerBrowser::OnBrowserShortcutClicked(

int event_flags) {

if (event_flags & ui::EF_CONTROL_DOWN) {