chrome/browser/ui/ash/launcher/chrome_launcher_controller_per_browser.h - Issue 14328031: Adding a minimize function for clicks on launcher items if only a single item (already active) is a…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/ash/launcher/chrome_launcher_controller_per_browser.h

Issue 14328031: Adding a minimize function for clicks on launcher items if only a single item (already active) is a… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Added one unit test and addressed comments Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/ash/launcher/chrome_launcher_controller_per_app_browsertest.cc ('k') | chrome/browser/ui/ash/launcher/chrome_launcher_controller_per_browser.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/ash/launcher/chrome_launcher_controller_per_browser.h

diff --git a/chrome/browser/ui/ash/launcher/chrome_launcher_controller_per_browser.h b/chrome/browser/ui/ash/launcher/chrome_launcher_controller_per_browser.h

index a88b98f153e21fcc6dae67eab308d243c209d56f..a133f4b3a95a8adec3d70c69c5c6d77db6ae5361 100644

--- a/chrome/browser/ui/ash/launcher/chrome_launcher_controller_per_browser.h

+++ b/chrome/browser/ui/ash/launcher/chrome_launcher_controller_per_browser.h

@@ -30,6 +30,7 @@

#include "ui/aura/window_observer.h"

class AppSyncUIState;

+class BaseWindow;

class Browser;

class BrowserLauncherItemControllerTest;

class ExtensionEnableFlow;

@@ -241,6 +242,11 @@ class ChromeLauncherControllerPerBrowser

virtual const extensions::Extension* GetExtensionForAppID(

const std::string& app_id) const OVERRIDE;

+ // Activates a |window|. If |allow_minimize| is true and the system allows

+ // it, the the window will get minimized instead.

+ virtual void ActivateWindowOrMinimizeIfActive(BaseWindow* window,

+ bool allow_minimize) OVERRIDE;

// ash::LauncherDelegate overrides:

virtual void OnBrowserShortcutClicked(int event_flags) OVERRIDE;

virtual void ItemClicked(const ash::LauncherItem& item,