Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(568)

Issue 1432783005: Add fuzzer-collapse-function-sk and demo (Closed)

Created:
5 years, 1 month ago by kjlubick
Modified:
5 years, 1 month ago
Reviewers:
KevinL, jcgregorio
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/buildbot@details3
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Remove unnecessary flexbox stuff #

Total comments: 1

Patch Set 3 : Whitespace change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+172 lines, -2 lines) Patch
M fuzzer/res/imp/fuzzer-collapse-details-sk.html View 1 chunk +2 lines, -2 lines 0 comments Download
A fuzzer/res/imp/fuzzer-collapse-function-sk.html View 1 2 1 chunk +124 lines, -0 lines 0 comments Download
A fuzzer/res/imp/fuzzer-collapse-function-sk-demo.html View 1 chunk +46 lines, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 9 (5 generated)
KevinL
5 years, 1 month ago (2015-11-06 17:36:10 UTC) #4
jcgregorio
LGTM modulo the blank line. https://codereview.chromium.org/1432783005/diff/20001/fuzzer/res/imp/fuzzer-collapse-function-sk.html File fuzzer/res/imp/fuzzer-collapse-function-sk.html (right): https://codereview.chromium.org/1432783005/diff/20001/fuzzer/res/imp/fuzzer-collapse-function-sk.html#newcode25 fuzzer/res/imp/fuzzer-collapse-function-sk.html:25: Methods: Blank line before.
5 years, 1 month ago (2015-11-06 18:55:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1432783005/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1432783005/40001
5 years, 1 month ago (2015-11-06 19:04:02 UTC) #8
commit-bot: I haz the power
5 years, 1 month ago (2015-11-06 19:06:00 UTC) #9
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/buildbot/+/88aecb51b2908399da055d4da7a5a8bb2577...

Powered by Google App Engine
This is Rietveld 408576698