Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 1413233007: Add fuzzer-collapse-file-sk and fuzzer-summary-list-sk (Closed)

Created:
5 years, 1 month ago by kjlubick
Modified:
5 years, 1 month ago
Reviewers:
KevinL, jcgregorio
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/buildbot@file-function
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Screenshot of fuzzer-collapse-file-sk: https://screenshot.googleplex.com/LQ3NnyfKUBj Collapsed screenshot of fuzzer-summary-list-sk: https://screenshot.googleplex.com/wGO7zvC9ei0 (Semi-)expanded screenshot of fuzzer-summary-list-sk: https://screenshot.googleplex.com/p56RiMKz9Uy BUG=skia:4438 Committed: https://skia.googlesource.com/buildbot/+/5a872b91a1bf361bf399a37a351e7968a807b2c4

Patch Set 1 #

Total comments: 1

Patch Set 2 : Revert import removals #

Patch Set 3 : Unnecessary flexing removed #

Total comments: 2

Patch Set 4 : Address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+272 lines, -0 lines) Patch
A fuzzer/res/imp/fuzzer-collapse-file-sk.html View 1 1 chunk +123 lines, -0 lines 0 comments Download
A fuzzer/res/imp/fuzzer-collapse-file-sk-demo.html View 1 1 chunk +58 lines, -0 lines 0 comments Download
M fuzzer/res/imp/fuzzer-collapse-function-sk.html View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A fuzzer/res/imp/fuzzer-summary-list-sk.html View 1 2 3 1 chunk +54 lines, -0 lines 0 comments Download
A fuzzer/res/imp/fuzzer-summary-list-sk-demo.html View 1 1 chunk +36 lines, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 14 (8 generated)
KevinL
5 years, 1 month ago (2015-11-06 18:03:19 UTC) #4
jcgregorio
https://codereview.chromium.org/1413233007/diff/1/fuzzer/res/imp/fuzzer-collapse-details-sk.html File fuzzer/res/imp/fuzzer-collapse-details-sk.html (left): https://codereview.chromium.org/1413233007/diff/1/fuzzer/res/imp/fuzzer-collapse-details-sk.html#oldcode44 fuzzer/res/imp/fuzzer-collapse-details-sk.html:44: <link rel="import" href="fuzzer-stacktrace-sk.html"> Every element should import its dependencies, ...
5 years, 1 month ago (2015-11-06 18:48:49 UTC) #5
KevinL
Undid the import removal
5 years, 1 month ago (2015-11-06 19:01:39 UTC) #6
jcgregorio
LGTM modulo the suggested changes. There seems to be a lot of repetition between all ...
5 years, 1 month ago (2015-11-06 19:15:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1413233007/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1413233007/60001
5 years, 1 month ago (2015-11-06 20:19:21 UTC) #13
commit-bot: I haz the power
5 years, 1 month ago (2015-11-06 20:21:15 UTC) #14
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/buildbot/+/5a872b91a1bf361bf399a37a351e7968a807...

Powered by Google App Engine
This is Rietveld 408576698