Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1412523004: Add fuzzer-collapse-details-sk and demo (Closed)

Created:
5 years, 1 month ago by kjlubick
Modified:
5 years, 1 month ago
Reviewers:
KevinL, jcgregorio
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/buildbot@stacktrace2
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : With indentation fixed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+299 lines, -2 lines) Patch
M fuzzer/res/imp/README.md View 1 chunk +5 lines, -0 lines 0 comments Download
A fuzzer/res/imp/fuzzer-collapse-details-sk.html View 1 1 chunk +256 lines, -0 lines 0 comments Download
A fuzzer/res/imp/fuzzer-collapse-details-sk-demo.html View 1 chunk +36 lines, -0 lines 0 comments Download
M fuzzer/res/imp/fuzzer-stacktrace-sk.html View 1 chunk +2 lines, -2 lines 0 comments Download

Depends on Patchset:

Issue 1410383012 Patch 20001

Dependent Patchsets:

Issue 1432783005 Patch 1
Issue 1432783005 Patch 20001
Issue 1432783005 Patch 40001

Messages

Total messages: 9 (5 generated)
KevinL
5 years, 1 month ago (2015-11-06 16:10:55 UTC) #4
jcgregorio
lgtm https://codereview.chromium.org/1412523004/diff/1/fuzzer/res/imp/fuzzer-collapse-details-sk.html File fuzzer/res/imp/fuzzer-collapse-details-sk.html (right): https://codereview.chromium.org/1412523004/diff/1/fuzzer/res/imp/fuzzer-collapse-details-sk.html#newcode140 fuzzer/res/imp/fuzzer-collapse-details-sk.html:140: <span class="center">Showing {{toShow}}/{{totalCount}}</span> indent
5 years, 1 month ago (2015-11-06 16:40:45 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1412523004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1412523004/20001
5 years, 1 month ago (2015-11-06 17:01:32 UTC) #8
commit-bot: I haz the power
5 years, 1 month ago (2015-11-06 17:03:32 UTC) #9
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/buildbot/+/dacc384cd9218bfddfca12505f8259a0f8db...

Powered by Google App Engine
This is Rietveld 408576698