GN: Avoid nontrivial shell commands in gcc_toolchain tool("link")

remoting/client/plugin/BUILD.gn

Index: remoting/client/plugin/BUILD.gn
diff --git a/remoting/client/plugin/BUILD.gn b/remoting/client/plugin/BUILD.gn
index 9f3d8ceb5057e381d7082f976cfc75b2d6852439..6c6d7f9fb721bd1cdc179dce0314f9c1e6977bb5 100644
--- a/remoting/client/plugin/BUILD.gn
+++ b/remoting/client/plugin/BUILD.gn
@@ -5,6 +5,7 @@
 assert(is_nacl,
        "These targets must only be built using the untrusted NaCl toolchains.")
 
+import("//build/config/features.gni")
 import("//remoting/remoting_srcs.gni")
 
 config("enable_linker_optimization") {
@@ -40,3 +41,23 @@ executable("remoting_client_plugin_newlib") {
 
   include_dirs = [ "//ppapi/lib/gl/include" ]
 }
+
+if (enable_pnacl && is_debug) {

[Sergey Ulanov, 2015/11/09 21:14:46]

Duplicating the target like this makes it harder to maintain that file. To make
it simpler maybe always copy the file?
Or perhaps a better solution is to add remoting_client_plugin_debug copy()
target and depend on it in remoting/webapp/build_template.gni only in debug
builds.

[Roland McGrath, 2015/11/09 21:30:21]

The "unstripped" (pre-finalized) file doesn't get saved anywhere if !is_debug,
so there is nothing to copy in that case.

I've changed the name of the copy rule as you suggested.

+  copy("remoting_client_plugin") {
+    public_deps = [
+      ":remoting_client_plugin_newlib",
+    ]
+    sources = [
+      "$root_out_dir/exe.unstripped/remoting_client_plugin_newlib.pexe",
+    ]
+    outputs = [
+      "$root_out_dir/remoting_client_plugin_newlib.pexe.debug",
+    ]
+  }
+} else {
+  group("remoting_client_plugin") {
+    public_deps = [
+      ":remoting_client_plugin_newlib",
+    ]
+  }
+}