remoting/webapp/build_template.gni - Issue 1432603003: GN: Avoid nontrivial shell commands in gcc_toolchain tool("link")

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: remoting/webapp/build_template.gni

Issue 1432603003: GN: Avoid nontrivial shell commands in gcc_toolchain tool("link") (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: remove workaround now that pnacl-finalize handles --strip-unneeded Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: remoting/webapp/build_template.gni

diff --git a/remoting/webapp/build_template.gni b/remoting/webapp/build_template.gni

index 3b8d9509f2ccb89951fc5f2f8caa3114315cec46..c1163d48be04c377d43191358e1228b7bbeef5d2 100644

--- a/remoting/webapp/build_template.gni

+++ b/remoting/webapp/build_template.gni

@@ -228,7 +228,7 @@ template("desktop_remoting_webapp") {

]

if (enable_pnacl) {

- deps += [ "//remoting/client/plugin:remoting_client_plugin_newlib(//build/toolchain/nacl:newlib_pnacl)" ]

+ deps += [ "//remoting/client/plugin:remoting_client_plugin(//build/toolchain/nacl:newlib_pnacl)" ]

}

# Create a file that contains a list of all the resource files needed

« remoting/client/plugin/BUILD.gn ('K') | « remoting/client/plugin/BUILD.gn ('k') | no next file » | no next file with comments »