GN: Avoid nontrivial shell commands in gcc_toolchain tool("link")

remoting/client/plugin/BUILD.gn

 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 assert(is_nacl,
        "These targets must only be built using the untrusted NaCl toolchains.")
 
+import("//build/config/features.gni")
 import("//remoting/remoting_srcs.gni")
 
 config("enable_linker_optimization") {
   ldflags = [ "-Wl,-O1" ]
 }
 
 executable("remoting_client_plugin_newlib") {
   sources =
       rebase_path(remoting_srcs_gypi_values.remoting_client_plugin_sources,
                   ".",
@@ skipping 15 matching lines @@
     "//remoting/client",
     "//remoting/codec",
     "//remoting/protocol",
     "//third_party/libyuv",
     "//third_party/webrtc/modules/desktop_capture:primitives",
     "//ui/events:dom_keycode_converter",
   ]
 
   include_dirs = [ "//ppapi/lib/gl/include" ]
 }
+
+if (enable_pnacl && is_debug) {

[Sergey Ulanov, 2015/11/09 21:14:46]

Duplicating the target like this makes it harder to maintain that file. To make
it simpler maybe always copy the file?
Or perhaps a better solution is to add remoting_client_plugin_debug copy()
target and depend on it in remoting/webapp/build_template.gni only in debug
builds.

[Roland McGrath, 2015/11/09 21:30:21]

The "unstripped" (pre-finalized) file doesn't get saved anywhere if !is_debug,
so there is nothing to copy in that case.

I've changed the name of the copy rule as you suggested.

+  copy("remoting_client_plugin") {
+    public_deps = [
+      ":remoting_client_plugin_newlib",
+    ]
+    sources = [
+      "$root_out_dir/exe.unstripped/remoting_client_plugin_newlib.pexe",
+    ]
+    outputs = [
+      "$root_out_dir/remoting_client_plugin_newlib.pexe.debug",
+    ]
+  }
+} else {
+  group("remoting_client_plugin") {
+    public_deps = [
+      ":remoting_client_plugin_newlib",
+    ]
+  }
+}