Enable 'Browsing data volume counters on Desktop' by default.

Enable 'Browsing data volume counters on Desktop' by default.

This was approved for the Dev channel in crbug.com/548620.

BUG=548620
Committed: https://crrev.com/b3f105f17cb6ff224dc8892f2bde7b4cb4b24388
Cr-Commit-Position: refs/heads/master@{#358617}

[msramek, 2015-11-03 10:11:32]

msramek@chromium.org changed reviewers:
+ dbeam@chromium.org

[msramek, 2015-11-03 10:11:33]

Hi Dan,

can you please have a look at this? Normally I send these to estade@ or bauerb@,
but one of them is OOO and the other I'm already spamming with reviews... And
this review doesn't need much context.

Thanks!
Martin

[msramek, 2015-11-04 18:20:02]

msramek@chromium.org changed reviewers:
+ isherman@chromium.org

[msramek, 2015-11-04 18:20:03]

Ah, tests were failing because I didn't update histograms.xml.

Dan, can you PTAL?

+Ilya, please review histograms.xml.

Thanks,
Martin

[Ilya Sherman, 2015-11-04 23:07:15]

histograms.xml lgtm

[msramek, 2015-11-06 17:00:47]

Dan, friendly ping :-)

I'd like this to be enabled ASAP, so that it spends some time on Canary before I
get approval for Beta.

[msramek, 2015-11-09 17:25:26]

msramek@chromium.org changed reviewers:
+ stevenjb@chromium.org

[msramek, 2015-11-09 17:25:27]

...alternatively, Steven, can you please have a look?

In case Dan is OOO or something and I missed it.

[stevenjb, 2015-11-09 17:33:37]

The CQ bit was checked by stevenjb@chromium.org

[stevenjb, 2015-11-09 17:33:37]

The CQ bit was unchecked by stevenjb@chromium.org

[stevenjb, 2015-11-09 17:33:41]

lgtm

[msramek, 2015-11-09 17:39:01]

Thanks!

[msramek, 2015-11-09 17:39:08]

The CQ bit was checked by msramek@chromium.org

[commit-bot: I haz the power, 2015-11-09 17:39:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1432563002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1432563002/20001

[commit-bot: I haz the power, 2015-11-09 18:57:50]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-11-09 18:59:34]

Patchset 2 (id:??) landed as
https://crrev.com/b3f105f17cb6ff224dc8892f2bde7b4cb4b24388
Cr-Commit-Position: refs/heads/master@{#358617}

[Peter Mayo, 2015-11-09 21:43:54]

On 2015/11/09 18:59:34, commit-bot: I haz the power wrote:
> Patchset 2 (id:??) landed as
> https://crrev.com/b3f105f17cb6ff224dc8892f2bde7b4cb4b24388
> Cr-Commit-Position: refs/heads/master@{#358617}

This seems to cause
https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%...

[Peter Mayo, 2015-11-09 21:46:28]

petermayo@chromium.org changed reviewers:
+ petermayo@chromium.org

[Peter Mayo, 2015-11-09 21:46:29]

https://codereview.chromium.org/1432563002/diff/20001/chrome/browser/about_fl...
File chrome/browser/about_flags.cc (right):

https://codereview.chromium.org/1432563002/diff/20001/chrome/browser/about_fl...
chrome/browser/about_flags.cc:2008: switches::kDisableClearBrowsingDataCounters)
This includes OS_CHROMEOS.

It doesn't seem like the tests stay happy when it does.
Please fix the code or tests appropriately.

[Peter Mayo, 2015-11-09 22:11:06]

Reverting at https://codereview.chromium.org/1423373006/

[msramek, 2015-11-09 22:48:04]

https://codereview.chromium.org/1432563002/diff/20001/chrome/browser/about_fl...
File chrome/browser/about_flags.cc (right):

https://codereview.chromium.org/1432563002/diff/20001/chrome/browser/about_fl...
chrome/browser/about_flags.cc:2008: switches::kDisableClearBrowsingDataCounters)
On 2015/11/09 21:46:29, Peter Mayo wrote:
> This includes OS_CHROMEOS.
> 
> It doesn't seem like the tests stay happy when it does.
> Please fix the code or tests appropriately.

Hm, I see the problem in HistoryCounter. It's not caused by this CL, but it is
exposed by it. I'll fix it tomorrow and reland this. Sorry for the trouble!