Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 1432413003: Implement UXTB and UXTH in the ARM integerated assembler. (Closed)

Created:
5 years, 1 month ago by Karl
Modified:
5 years, 1 month ago
Reviewers:
Jim Stichnoth, sehr, John
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Fix nits and add comments in DART code. #

Patch Set 3 : Merge with master. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+173 lines, -0 lines) Patch
M src/DartARM32/assembler_arm.h View 1 1 chunk +6 lines, -0 lines 0 comments Download
M src/IceAssemblerARM32.h View 1 2 3 chunks +17 lines, -0 lines 0 comments Download
M src/IceAssemblerARM32.cpp View 1 2 4 chunks +56 lines, -0 lines 0 comments Download
M src/IceInstARM32.cpp View 1 2 1 chunk +8 lines, -0 lines 0 comments Download
A tests_lit/assembler/arm32/uxtb.ll View 1 1 chunk +86 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Karl
5 years, 1 month ago (2015-11-11 23:31:42 UTC) #3
Jim Stichnoth
lgtm
5 years, 1 month ago (2015-11-11 23:37:11 UTC) #4
Karl
5 years, 1 month ago (2015-11-11 23:42:58 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
bb0bacfda50db67da64e92ed2a79d590ec3cbcd1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698