chromecast/browser/cast_content_window.cc - Issue 1432143002: Track where WebContents are created in order to better understand issue.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromecast/browser/cast_content_window.cc

Issue 1432143002: Track where WebContents are created in order to better understand issue. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« blimp/engine/browser/blimp_engine_session.cc ('K') | « chrome/browser/ui/webui/constrained_web_dialog_delegate_base.cc ('k') | components/constrained_window/DEPS » ('j') | components/constrained_window/constrained_window_views.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chromecast/browser/cast_content_window.cc

diff --git a/chromecast/browser/cast_content_window.cc b/chromecast/browser/cast_content_window.cc

index aa3d6837e318f8aa22df69780555d35820f3076e..a26b08d0278fbc985b16339cae13b051a1881984 100644

--- a/chromecast/browser/cast_content_window.cc

+++ b/chromecast/browser/cast_content_window.cc

@@ -12,6 +12,7 @@

#include "content/public/browser/render_widget_host.h"

#include "content/public/browser/render_widget_host_view.h"

#include "content/public/browser/web_contents.h"

+#include "content/public/browser/web_contents_source.h"

#include "ipc/ipc_message.h"

#if defined(USE_AURA)

@@ -114,6 +115,7 @@ scoped_ptr<content::WebContents> CastContentWindow::CreateWebContents(

create_params.initial_size = initial_size;

content::WebContents* web_contents = content::WebContents::Create(

create_params);

+ WebContentsSource::CreateForWebContentsAndLocation(web_contents, FROM_HERE);

halliwell 2015/11/11 14:14:31 Think you can revert this file, your crash isn't i

hcarmona 2015/11/11 19:57:58 Done.

content::WebContentsObserver::Observe(web_contents);

return make_scoped_ptr(web_contents);

}