chrome/browser/ui/webui/constrained_web_dialog_delegate_base.cc - Issue 1432143002: Track where WebContents are created in order to better understand issue.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/constrained_web_dialog_delegate_base.cc

Issue 1432143002: Track where WebContents are created in order to better understand issue. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« blimp/engine/browser/blimp_engine_session.cc ('K') | « chrome/browser/ui/panels/panel_host.cc ('k') | chromecast/browser/cast_content_window.cc » ('j') | chromecast/browser/cast_content_window.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/constrained_web_dialog_delegate_base.cc

diff --git a/chrome/browser/ui/webui/constrained_web_dialog_delegate_base.cc b/chrome/browser/ui/webui/constrained_web_dialog_delegate_base.cc

index fd60a4b0d6cce71e6b91bacac6bccee1e925abe6..9b10a8a47643d180613085f5abc8a78c56594bcc 100644

--- a/chrome/browser/ui/webui/constrained_web_dialog_delegate_base.cc

+++ b/chrome/browser/ui/webui/constrained_web_dialog_delegate_base.cc

@@ -12,6 +12,7 @@

#include "components/ui/zoom/zoom_controller.h"

#include "content/public/browser/render_view_host.h"

#include "content/public/browser/web_contents.h"

+#include "content/public/browser/web_contents_source.h"

#include "content/public/common/renderer_preferences.h"

#include "ipc/ipc_message.h"

#include "ui/web_dialogs/web_dialog_delegate.h"

@@ -34,6 +35,8 @@ ConstrainedWebDialogDelegateBase::ConstrainedWebDialogDelegateBase(

CHECK(delegate);

web_contents_.reset(

WebContents::Create(WebContents::CreateParams(browser_context)));

+ WebContentsSource::CreateForWebContentsAndLocation(web_contents_.get(),

+ FROM_HERE);

ui_zoom::ZoomController::CreateForWebContents(web_contents_.get());

if (tab_delegate) {

override_tab_delegate_.reset(tab_delegate);