blimp/engine/browser/blimp_engine_session.cc - Issue 1432143002: Track where WebContents are created in order to better understand issue.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: blimp/engine/browser/blimp_engine_session.cc

Issue 1432143002: Track where WebContents are created in order to better understand issue. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« android_webview/lib/aw_browser_dependency_factory_impl.cc ('K') | « apps/custom_launcher_page_contents.cc ('k') | chrome/browser/android/tab_state.cc » ('j') | chromecast/browser/cast_content_window.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: blimp/engine/browser/blimp_engine_session.cc

diff --git a/blimp/engine/browser/blimp_engine_session.cc b/blimp/engine/browser/blimp_engine_session.cc

index 6ffd79dabdbee355d0383aee2861d41584e3e79d..e76dd8c2f86af6de58cbc593408d7fad128f3902 100644

--- a/blimp/engine/browser/blimp_engine_session.cc

+++ b/blimp/engine/browser/blimp_engine_session.cc

@@ -17,6 +17,7 @@

#include "content/public/browser/render_view_host.h"

#include "content/public/browser/render_widget_host.h"

#include "content/public/browser/web_contents.h"

+#include "content/public/browser/web_contents_source.h"

#include "ui/aura/client/default_capture_client.h"

#include "ui/aura/env.h"

#include "ui/aura/window.h"

@@ -93,6 +94,8 @@ void BlimpEngineSession::CreateWebContents(const int target_tab_id) {

nullptr);

scoped_ptr<content::WebContents> new_contents =

make_scoped_ptr(content::WebContents::Create(create_params));

+ WebContentsSource::CreateForWebContentsAndLocation(web_contents.get(),

Mike Wittman 2015/11/11 17:15:28 I don't think blimp is used on desktop, so this pr

hcarmona 2015/11/11 19:57:58 Done.

+ FROM_HERE);

PlatformSetContents(new_contents.Pass());

}