Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 1431593003: [es6] Fix RegExp built-in subclassing. (Closed)

Created:
5 years, 1 month ago by Igor Sheludko
Modified:
5 years, 1 month ago
Reviewers:
Toon Verwaest
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[es6] Fix RegExp built-in subclassing. 1) The Map::CopyInitialMap() did not set descriptor's array if the source initial map had one. 2) Subclasses are temporarily disallowed to have more in-object properties than the parent class (for GC reasons). BUG=v8:3101, v8:3330, v8:4531 LOG=N Committed: https://crrev.com/678a5583d6e15ee81546f7e4a23a21dc5cfe8012 Cr-Commit-Position: refs/heads/master@{#31743}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -2 lines) Patch
M src/objects.cc View 2 chunks +22 lines, -1 line 0 comments Download
M test/mjsunit/es6/classes-subclass-builtins.js View 17 chunks +25 lines, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 20 (11 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1431593003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1431593003/60001
5 years, 1 month ago (2015-11-02 18:23:39 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux64_asan_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel/builds/9634) v8_linux_mips64el_compile_rel on ...
5 years, 1 month ago (2015-11-02 18:24:32 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1431593003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1431593003/80001
5 years, 1 month ago (2015-11-02 19:22:48 UTC) #11
Igor Sheludko
PTAL
5 years, 1 month ago (2015-11-02 19:27:53 UTC) #13
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-02 19:47:22 UTC) #15
Toon Verwaest
lgtm
5 years, 1 month ago (2015-11-03 09:46:48 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1431593003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1431593003/80001
5 years, 1 month ago (2015-11-03 12:14:22 UTC) #18
commit-bot: I haz the power
Committed patchset #1 (id:80001)
5 years, 1 month ago (2015-11-03 12:15:53 UTC) #19
commit-bot: I haz the power
5 years, 1 month ago (2015-11-03 12:16:23 UTC) #20
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/678a5583d6e15ee81546f7e4a23a21dc5cfe8012
Cr-Commit-Position: refs/heads/master@{#31743}

Powered by Google App Engine
This is Rietveld 408576698