Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issue 1415683007: Reland "[es6] Fix Function and GeneratorFunction built-ins subclassing." (Closed)

Created:
5 years, 1 month ago by Igor Sheludko
Modified:
5 years, 1 month ago
Reviewers:
Toon Verwaest
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@fix-subclass
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland "[es6] Fix Function and GeneratorFunction built-ins subclassing." Original issue's description: > [es6] Fix Function and GeneratorFunction built-ins subclassing. > > BUG=v8:3101, v8:3330 > LOG=Y > > Committed: https://crrev.com/99e7f872d3d0a5fb799dcbafb05537cda491314a > Cr-Commit-Position: refs/heads/master@{#31708} The problem was in another CL, this is a clean reland with improved tests. BUG=v8:3101, v8:3330 LOG=Y Committed: https://crrev.com/babe50f083baf0cf1afa3106f616729f3ae940d7 Cr-Commit-Position: refs/heads/master@{#31756}

Patch Set 1 #

Patch Set 2 : Improved test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+139 lines, -32 lines) Patch
M src/bootstrapper.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M src/factory.h View 1 chunk +5 lines, -2 lines 0 comments Download
M src/factory.cc View 1 chunk +13 lines, -2 lines 0 comments Download
M src/js/generator.js View 1 chunk +5 lines, -3 lines 0 comments Download
M src/js/v8natives.js View 1 chunk +5 lines, -3 lines 0 comments Download
M src/objects-printer.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/runtime-function.cc View 1 chunk +33 lines, -5 lines 0 comments Download
M src/runtime/runtime-object.cc View 1 chunk +6 lines, -14 lines 0 comments Download
M test/mjsunit/es6/classes-subclass-builtins.js View 1 2 chunks +64 lines, -0 lines 0 comments Download
M test/mjsunit/regress/regress-function-constructor-receiver.js View 1 chunk +2 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 17 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1415683007/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1415683007/20001
5 years, 1 month ago (2015-11-02 19:52:44 UTC) #2
Igor Sheludko
PTAL The problem that caused issues with this CL is addressed here: https://codereview.chromium.org/1431593003/
5 years, 1 month ago (2015-11-02 19:53:42 UTC) #4
Igor Sheludko
PTAL The problem that caused issues with this CL is addressed here: https://codereview.chromium.org/1431593003/ This is ...
5 years, 1 month ago (2015-11-02 19:54:30 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel/builds/11278)
5 years, 1 month ago (2015-11-02 20:14:17 UTC) #7
Toon Verwaest
lgtm
5 years, 1 month ago (2015-11-03 11:59:40 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1415683007/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1415683007/20001
5 years, 1 month ago (2015-11-03 16:23:06 UTC) #11
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-03 16:40:10 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1415683007/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1415683007/20001
5 years, 1 month ago (2015-11-03 16:40:53 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-03 16:42:26 UTC) #16
commit-bot: I haz the power
5 years, 1 month ago (2015-11-03 16:42:51 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/babe50f083baf0cf1afa3106f616729f3ae940d7
Cr-Commit-Position: refs/heads/master@{#31756}

Powered by Google App Engine
This is Rietveld 408576698