Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(986)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1410023013: Objects printing improved a bit. (Closed)

Created:
5 years, 1 month ago by Igor Sheludko
Modified:
5 years, 1 month ago
Reviewers:
Toon Verwaest
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@fix-subclass
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Objects printing improved a bit. Committed: https://crrev.com/0f6092a41fbd27e8a3e2818eb0948891bfa7459a Cr-Commit-Position: refs/heads/master@{#31744}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -94 lines) Patch
M src/objects.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/objects.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M src/objects-printer.cc View 24 chunks +91 lines, -90 lines 0 comments Download

Depends on Patchset:

Issue 1431593003 Patch 80001

Messages

Total messages: 11 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1410023013/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1410023013/1
5 years, 1 month ago (2015-11-02 19:23:48 UTC) #2
Igor Sheludko
PTAL
5 years, 1 month ago (2015-11-02 19:42:09 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-02 19:45:13 UTC) #6
Toon Verwaest
lgtm
5 years, 1 month ago (2015-11-03 09:45:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1410023013/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1410023013/1
5 years, 1 month ago (2015-11-03 13:19:16 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-03 13:20:27 UTC) #10
commit-bot: I haz the power
5 years, 1 month ago (2015-11-03 13:20:57 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/0f6092a41fbd27e8a3e2818eb0948891bfa7459a
Cr-Commit-Position: refs/heads/master@{#31744}

Powered by Google App Engine
This is Rietveld 408576698